Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with rosdistro_freeze_source and annotated tags #91

Open
mikepurvis opened this issue Nov 8, 2016 · 0 comments
Open

Issues with rosdistro_freeze_source and annotated tags #91

mikepurvis opened this issue Nov 8, 2016 · 0 comments

Comments

@mikepurvis
Copy link
Contributor

mikepurvis commented Nov 8, 2016

I don't have a solution for this at the moment, but we got recently bit by a case where a source stanza's version attribute was referencing an annotated tag, which broke our builds.

So far as I can tell, the trouble was that the hash for the tag itself wasn't recognized by github as a commit in the tree and couldn't be used in the URL or by the API as a ref (for example, to find package.xml files)—you have to dereference it first. We've worked around this by switching it to a lightweight tag, but wanted to leave this as a heads-up to any future travellers.

@dirk-thomas dirk-thomas added this to the untargeted milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants