Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sequences of steps #40

Closed
krlmlr opened this issue Jan 30, 2018 · 3 comments
Closed

Support sequences of steps #40

krlmlr opened this issue Jan 30, 2018 · 3 comments

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Jan 30, 2018

get_stage("deploy") %>%
  sequence_start("pkgdown") %>%
  step_build_pkgdown() %>%
  step_push_deploy() %>%
  sequence_stop("pkgdown")

Need a better name for it.

@maelle
Copy link
Member

maelle commented Jun 13, 2018

A recipe?

@krlmlr
Copy link
Collaborator Author

krlmlr commented Jun 28, 2018

This solves the problem of supporting early vs. deferred failure: currently, all steps of a stage are run even if some steps fail, but this doesn't make sense in deployment scenarios. Switching to early failure everywhere is much easier and more consistent with user's expectation.

We can then think of supporting the opposite: defining a "keep going" switch that enables deferred failure:

get_stage("script") %>%
  set_keep_going() %>%

  # Run R CMD check
  step_rcmdcheck() %>%

  # lint the R source code
  step_lint() %>%

  # lint the documentation web page
  step_weblint()

@krlmlr
Copy link
Collaborator Author

krlmlr commented Jun 28, 2018

Closing in favor of #59 and #60.

@krlmlr krlmlr closed this as completed Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants