Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance rethinkdb/rethinkdb-go #507

Open
DanyHenriquez opened this issue Oct 12, 2023 · 20 comments
Open

Maintenance rethinkdb/rethinkdb-go #507

DanyHenriquez opened this issue Oct 12, 2023 · 20 comments
Assignees

Comments

@DanyHenriquez
Copy link

I would like to take over updating and maintaining the rethinkdb/rethinkdb-go. At this moment there seems to be no reliable update mechanism and it seems abandoned. I want to change that.

First PR is already there so we can make some progress. After that i will check what more i can do there.

@gabor-boros gabor-boros self-assigned this Dec 12, 2023
@gabor-boros
Copy link
Member

@DanyHenriquez I'm a little bit late on this. Are you still interested?

@gabor-boros gabor-boros transferred this issue from rethinkdb/rethinkdb Dec 18, 2023
@DanyHenriquez
Copy link
Author

DanyHenriquez commented Jan 17, 2024

@DanyHenriquez I'm a little bit late on this. Are you still interested?

@gabor-boros
Hello. I have not been checking my issues for a while, but I would be interested in maintaining the repo and doing updates.

@gabor-boros
Copy link
Member

@DanyHenriquez Then I'd be happy to collaborate with you. I'll go through the open PRs this week and review them. If you need any help/info/resource/etc, just let me know.

At the moment, CMogilko and I are in the GitHub team that can update the repo directly. I did not do any maintenance lately (as visible), however, I'm happy to pick up the track again. Also, if you are interested on the long run, I'm happy to give you access to the repo as a maintainer after some PRs, so you don't have to hassle with forks.

@CMogilko
Copy link
Member

I do not work with rethinkdb anymore, so no time to do maintenance, sorry.

@DanyHenriquez
Copy link
Author

@gabor-boros @CMogilko

I will work on some PR's and try to resolve some issues next week.

@majst01
Copy link

majst01 commented May 1, 2024

@DanyHenriquez would also help here, already have some fork which updated the whole codebase a bit

https://github.com/majst01/rethinkdb-go/tree/go-1.22

@DanyHenriquez
Copy link
Author

@majst01 Its great to have an updated code base, but would it not be better to merge it all back to this repository?

Then we have one source of truth in stead of forks.

I'm willing to help, but I'm not willing to help with maintaining a fork of the original unless the original project maintainer is MIA.

Great work nonetheless!

@majst01
Copy link

majst01 commented May 3, 2024

@majst01 Its great to have an updated code base, but would it not be better to merge it all back to this repository?

Then we have one source of truth in stead of forks.

I'm willing to help, but I'm not willing to help with maintaining a fork of the original unless the original project maintainer is MIA.

Great work nonetheless!

Sure, my goal is of course to get this merged, but i first want to test our sw with this before opening PRs. And it should be split into several PRs for better reviewability.

But it seems to me that right now, no one is reviewing PRs.

@SOG-web
Copy link

SOG-web commented Oct 4, 2024

@majst01 and @DanyHenriquez please any update on this

@majst01
Copy link

majst01 commented Oct 4, 2024

No response from the maintainer yet to my suggestion.

@SOG-web
Copy link

SOG-web commented Oct 4, 2024

No response from the maintainer yet to my suggestion.

@gabor-boros please any update or can we go ahead to create a maintained fork

@majst01 have tested your updated version, can i install it directly

generally i also wanted to know if this supports serialization and deserialization, I mean can i do something like this

query := 'r.table(...).filter(...).map(...).serialize()'
r.deserialize(serializedQuery).run()

@majst01
Copy link

majst01 commented Oct 4, 2024

No response from the maintainer yet to my suggestion.

@gabor-boros please any update or can we go ahead to create a maintained fork

@majst01 have tested your updated version, can i install it directly

just add a replace in your go.mod

replace gopkg.in/rethinkdb/rethinkdb-go.v6 => github.com/majst01/rethinkdb-go go-1.22

generally i also wanted to know if this supports serialization and deserialization, I mean can i do something like this

query := 'r.table(...).filter(...).map(...).serialize()'
r.deserialize(serializedQuery).run()

I didnt change any functionality.

@SOG-web
Copy link

SOG-web commented Oct 4, 2024

No response from the maintainer yet to my suggestion.

@gabor-boros please any update or can we go ahead to create a maintained fork
@majst01 have tested your updated version, can i install it directly

just add a replace in your go.mod

replace gopkg.in/rethinkdb/rethinkdb-go.v6 => github.com/majst01/rethinkdb-go go-1.22

generally i also wanted to know if this supports serialization and deserialization, I mean can i do something like this

query := 'r.table(...).filter(...).map(...).serialize()'
r.deserialize(serializedQuery).run()

I didnt change any functionality.

go mod tidy
go: serverkit.com/cmd imports github.com/majst01/rethinkdb-go: github.com/majst01/[email protected]: parsing go.mod: module declares its path as: gopkg.in/rethinkdb/rethinkdb-go.v6 but was required as: github.com/majst01/rethinkdb-go

mod file
github.com/majst01/rethinkdb-go go-1.22 // indirect

@SOG-web
Copy link

SOG-web commented Oct 4, 2024

No response from the maintainer yet to my suggestion.

@gabor-boros please any update or can we go ahead to create a maintained fork
@majst01 have tested your updated version, can i install it directly

just add a replace in your go.mod

replace gopkg.in/rethinkdb/rethinkdb-go.v6 => github.com/majst01/rethinkdb-go go-1.22

generally i also wanted to know if this supports serialization and deserialization, I mean can i do something like this

query := 'r.table(...).filter(...).map(...).serialize()'
r.deserialize(serializedQuery).run()

I didnt change any functionality.

go mod tidy go: serverkit.com/cmd imports github.com/majst01/rethinkdb-go: github.com/majst01/[email protected]: parsing go.mod: module declares its path as: gopkg.in/rethinkdb/rethinkdb-go.v6 but was required as: github.com/majst01/rethinkdb-go

mod file github.com/majst01/rethinkdb-go go-1.22 // indirect

go mod tidy go: errors parsing go.mod: go.mod:23:2: require github.com/majst01/rethinkdb-go: version "v6.2.2" invalid: should be v0 or v1, not v6
mod file
github.com/majst01/rethinkdb-go v6.2.2

@majst01
Copy link

majst01 commented Oct 4, 2024

No response from the maintainer yet to my suggestion.

@gabor-boros please any update or can we go ahead to create a maintained fork
@majst01 have tested your updated version, can i install it directly

just add a replace in your go.mod

replace gopkg.in/rethinkdb/rethinkdb-go.v6 => github.com/majst01/rethinkdb-go go-1.22

generally i also wanted to know if this supports serialization and deserialization, I mean can i do something like this

query := 'r.table(...).filter(...).map(...).serialize()'
r.deserialize(serializedQuery).run()

I didnt change any functionality.

go mod tidy go: serverkit.com/cmd imports github.com/majst01/rethinkdb-go: github.com/majst01/[email protected]: parsing go.mod: module declares its path as: gopkg.in/rethinkdb/rethinkdb-go.v6 but was required as: github.com/majst01/rethinkdb-go
mod file github.com/majst01/rethinkdb-go go-1.22 // indirect

go mod tidy go: errors parsing go.mod: go.mod:23:2: require github.com/majst01/rethinkdb-go: version "v6.2.2" invalid: should be v0 or v1, not v6 mod file github.com/majst01/rethinkdb-go v6.2.2

OK, my fault, try replacing with a local copy of my branch like so:

replace gopkg.in/rethinkdb/rethinkdb-go.v6 => ../rethinkdb-go

where the later is the clone of my branch

@gabor-boros
Copy link
Member

Hey @majst01 and @SOG-web,

Today later I'll take a look at this issue. I'm pretty happy to keep the ball rolling with this repository, though I need input from the community as I'm not using RethinkDB at the moment, hence I don't know the current pain points.

@SOG-web
Copy link

SOG-web commented Oct 4, 2024

Hey @majst01 and @SOG-web,

Today later I'll take a look at this issue. I'm pretty happy to keep the ball rolling with this repository, though I need input from the community as I'm not using RethinkDB at the moment, hence I don't know the current pain points.

thanks so much, I will sure send input. am currently building a go baas(backend as a service) with it

generally i also wanted to know if this supports serialization and deserialization, I mean can i do something like this

query := 'r.table(...).filter(...).map(...).serialize()'
r.deserialize(serializedQuery).run()

@SOG-web
Copy link

SOG-web commented Oct 4, 2024

Hey @majst01 and @SOG-web,
Today later I'll take a look at this issue. I'm pretty happy to keep the ball rolling with this repository, though I need input from the community as I'm not using RethinkDB at the moment, hence I don't know the current pain points.

thanks so much, I will sure send input. am currently building a go baas(backend as a service) with it

generally i also wanted to know if this supports serialization and deserialization, I mean can i do something like this

query := 'r.table(...).filter(...).map(...).serialize()'
r.deserialize(serializedQuery).run()

if the above is possible, I will be able to use the nodejs driver as a client(frontend) sdk to communicate with the go server

@SOG-web
Copy link

SOG-web commented Oct 4, 2024

@majst01 i think you can push the PR now

@majst01
Copy link

majst01 commented Oct 4, 2024

#508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants