Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to supply a custom SIWE in AppKit present UI #25

Open
itsallmememe opened this issue Oct 3, 2024 · 0 comments
Open

Add ability to supply a custom SIWE in AppKit present UI #25

itsallmememe opened this issue Oct 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@itsallmememe
Copy link

Is your feature request related to a problem? Please describe.
We use Privy.io for account management. Their login process requires that they create a SIWE string that is then sent to the a wallet for personal_sign. The resulting hash is then sent back to Privy for confirmation and final authentication.

The AppKit modal experience is great from a developer experience as we can call AppKit.present() and the entire auth journey is handled for us, but without the ability to add in a SIWE we cannot integrate this into our app.

Describe the solution you'd like
Something similar to this would be ideal

AppKit.present(from: UIViewController, properties: CustomProperties)

struct CustomProperties {
    ...
    let customSiwe: String?
    ...
}

This allows us to present the AppKit modal during presentation of the modal

Alternatively during configuration could work ok

public class AppKit {
    ...
    static func configure(projectId: String,
        metadata: AppMetadata,
        crypto: CryptoProvider,
        sessionParams: SessionParams = .default,
        authRequestParams: AuthRequestParams?,
        customSiweMessage: String?,
...
}

Could work ok, but we if authentication fails in Privy we would need to request a new SIWE from them, and then "re-configure" AppKit with this new SIWE which may not be the correct way to do things.

Describe alternatives you've considered
We already have integrated WalletConnect, but moving to a fully configured ReOwn AppKit solution would help us eradicate any connection bugs.

Additional context
n/a

@itsallmememe itsallmememe added the enhancement New feature or request label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant