Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making hoverxref_auto_ref = True the default? #163

Open
astrojuanlu opened this issue Dec 8, 2021 · 4 comments
Open

Consider making hoverxref_auto_ref = True the default? #163

astrojuanlu opened this issue Dec 8, 2021 · 4 comments
Labels
Needed: design decision A core team decision is required

Comments

@astrojuanlu
Copy link
Contributor

When @ericholscher and @humitos discussed this privately in April 2020, this was @humitos opinion:

it does not enable :ref: by default because I think it's too aggresive

However, after writing readthedocs/blog#144 I agree with @ericholscher that the default is a bit too conservative. I see the intention (providing a :hoverxref: role) but I think it has less friction if no conf.py changes are needed to see the extension in action with an existing project. On the other hand, "something migh break", but I think changing the default will actually help us detect such breakage.

Thoughts?

@ericholscher
Copy link
Member

I'm 👍 on defaulting to the most possible referencing, since that is what I'd expect as a user when I enable the extension. It feels weird to default to a subset of possible links, and really confusing to readers of the docs when random internal links don't hover.

@KanchiMoe
Copy link

I would decline, because :ref: (when combined with autosectionlabel) allows you to link to any header in the documentation - which, isn't something you can do without this extention.

Having hoverxref_auto_ref be true by default would mean that any interlinking using ref will show a tooltip.

I think the current set up is ideal where using :hoverxref: allows you to control having when a tooltip shows up.

@ericholscher
Copy link
Member

I'd really like to see this here.

Also I set this up, and got this error.. 🤔

Using default style (tooltip) for unknown typ (ref). Define it in hoverxref_role_types.

@ericholscher
Copy link
Member

cc @humitos -- I think there's some "first run" improvements we could do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

3 participants