Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: auto dismiss missing focusin/focusout events #381

Open
agjohnson opened this issue Sep 19, 2024 · 1 comment
Open

Notifications: auto dismiss missing focusin/focusout events #381

agjohnson opened this issue Sep 19, 2024 · 1 comment
Labels
Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Sep 19, 2024

Raising this as an issue, I commented on the PR here after it was merged. I didn't want this to get lost.

#375 (comment)

I had originally mentioned adding mouse and focus events to pause auto dismiss there. The focus events can be used by screen readers in the same way mouseover works for pointers. This also should cover keyboard focus.

@humitos humitos added the Improvement Minor improvement to code label Oct 10, 2024
@humitos
Copy link
Member

humitos commented Oct 10, 2024

We should probably take a look at how is the tab/keyboard order for these element. I'm not sure you are able to "focusin" the notification with the keyboard currently. I guess this is also related with accessibility too.

If you go to https://docs.readthedocs.io/en/latest/ and hit TAB multiple times, it does nothing. I'm not sure where the focus is, but I'm not able to move around the page with the keyboard. However, if you click on the content of the page and start hitting TAB, eventually, you will arrive at the notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

2 participants