Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Switch to pre-commit.ci service instead of custom pre-commit jobs #1091

Open
afuetterer opened this issue Jul 29, 2024 · 1 comment

Comments

@afuetterer
Copy link
Member

afuetterer commented Jul 29, 2024

I think it is actually better to switch to the established pre-commit.ci service.

It will run our lint job, and do periodic update PRs for the .pre-commit-config.yaml config.

Ref: https://pre-commit.ci/

@afuetterer
Copy link
Member Author

There is two thumbs up, which I guess means "yes, let's do it". This has to be done by someone with higher privileges. I can add the service only to my own repositories.

After you added it, we can configure it in .pre-commit-config.yaml.

It can generate an update PR, 'weekly', 'monthly' or 'quarterly'. I think monthly is a solid choice, between being up-to-date and having too much noise.

Also the service can "autofix" PRs, if you like. I am not a fan of that feature, I prefer to do that locally and have CI tell me if there is something wrong. But this is of course up for discussion.

Ref: https://pre-commit.ci/#configuration

@MyPyDavid MyPyDavid self-assigned this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants