Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RKE2/Containerd Not Applying Rewrite Rules in /etc/rancher/rke2/registries.yaml #6889

Open
dustin-groh-dev opened this issue Sep 27, 2024 · 1 comment

Comments

@dustin-groh-dev
Copy link

Environmental Info:

RKE2 v1.28.8
Rancher v2.8.3

Describe the bug:

When creating a new cluster via Rancher, RKE2 / containterd isn't applying the rewrite rules from /etc/rancher/rke2/registries.yaml specifically if the files have mirrors.[*].registry..... when the docs and example don't have that wildcard so it's potentially a formatting change that got missed.

Steps To Reproduce:

For a customer this was reproducible for any cluster they were attempting to create via pipeline as they use the same registries.yaml.
The fix was to edit the /var/lib/rancher/rke2/agent/etc/containerd/config.toml.tmpl to add in the mirror registry/rewrite rules and rerun the pipeline to create the cluster.

Expected behavior:

For RKE2 / containerd to apply the rewrite rules specified in the registries.yaml file even when they include a wildcard.

Additional context / logs:
Potentially related to #3227

@brandond
Copy link
Member

brandond commented Sep 28, 2024

I am not aware of any issues with rewrites. Can you provide a specific example of registries.yaml content that does not apply rewrites?

Note that rewrite rules ONLY apply when pulling images from a mirror endpoint; rewrites are NOT intended to apply when pulling an image directly from the registry itself (ie, when using the registry's default endpoint). If you add a wildcard entry with rewrites, but no endpoints, this is not expected to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants