From 0dc0ff539ba624139188dd943ed650dc60d3e9b8 Mon Sep 17 00:00:00 2001 From: jdhenshaw Date: Wed, 24 Jan 2024 13:47:22 +0100 Subject: [PATCH 1/3] added kwargs to ellipse_to_plot --- astropy_helpers | 1 + radio_beam/beam.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 160000 astropy_helpers diff --git a/astropy_helpers b/astropy_helpers new file mode 160000 index 0000000..e00c0ca --- /dev/null +++ b/astropy_helpers @@ -0,0 +1 @@ +Subproject commit e00c0ca476ba5baec3247a7d13b5d9f3531c1df1 diff --git a/radio_beam/beam.py b/radio_beam/beam.py index c76636f..93e5221 100644 --- a/radio_beam/beam.py +++ b/radio_beam/beam.py @@ -529,7 +529,7 @@ def commonbeam_with(self, other_beam): return find_commonbeam_between(self, other_beam) - def ellipse_to_plot(self, xcen, ycen, pixscale): + def ellipse_to_plot(self, xcen, ycen, pixscale, **kwargs): """ Return a matplotlib ellipse for plotting @@ -553,7 +553,7 @@ def ellipse_to_plot(self, xcen, ycen, pixscale): height=(self.minor.to(u.deg) / pixscale).to(u.dimensionless_unscaled).value, # PA is 90 deg offset from x-y axes by convention # (it is angle from NCP) - angle=(self.pa+90*u.deg).to(u.deg).value) + angle=(self.pa+90*u.deg).to(u.deg).value, **kwargs) def as_kernel(self, pixscale, **kwargs): """ From 186da1741cc029a663ef7cf6612c52aa21c8baea Mon Sep 17 00:00:00 2001 From: jdhenshaw Date: Wed, 24 Jan 2024 13:50:57 +0100 Subject: [PATCH 2/3] Revert "added kwargs to ellipse_to_plot" This reverts commit 0dc0ff539ba624139188dd943ed650dc60d3e9b8. --- astropy_helpers | 1 - radio_beam/beam.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) delete mode 160000 astropy_helpers diff --git a/astropy_helpers b/astropy_helpers deleted file mode 160000 index e00c0ca..0000000 --- a/astropy_helpers +++ /dev/null @@ -1 +0,0 @@ -Subproject commit e00c0ca476ba5baec3247a7d13b5d9f3531c1df1 diff --git a/radio_beam/beam.py b/radio_beam/beam.py index 93e5221..c76636f 100644 --- a/radio_beam/beam.py +++ b/radio_beam/beam.py @@ -529,7 +529,7 @@ def commonbeam_with(self, other_beam): return find_commonbeam_between(self, other_beam) - def ellipse_to_plot(self, xcen, ycen, pixscale, **kwargs): + def ellipse_to_plot(self, xcen, ycen, pixscale): """ Return a matplotlib ellipse for plotting @@ -553,7 +553,7 @@ def ellipse_to_plot(self, xcen, ycen, pixscale, **kwargs): height=(self.minor.to(u.deg) / pixscale).to(u.dimensionless_unscaled).value, # PA is 90 deg offset from x-y axes by convention # (it is angle from NCP) - angle=(self.pa+90*u.deg).to(u.deg).value, **kwargs) + angle=(self.pa+90*u.deg).to(u.deg).value) def as_kernel(self, pixscale, **kwargs): """ From 3c0848270cb97cd1e2a01888570be384baf12e00 Mon Sep 17 00:00:00 2001 From: jdhenshaw Date: Wed, 24 Jan 2024 13:54:51 +0100 Subject: [PATCH 3/3] added kwargs to ellipse to plot --- radio_beam/beam.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/radio_beam/beam.py b/radio_beam/beam.py index c76636f..93e5221 100644 --- a/radio_beam/beam.py +++ b/radio_beam/beam.py @@ -529,7 +529,7 @@ def commonbeam_with(self, other_beam): return find_commonbeam_between(self, other_beam) - def ellipse_to_plot(self, xcen, ycen, pixscale): + def ellipse_to_plot(self, xcen, ycen, pixscale, **kwargs): """ Return a matplotlib ellipse for plotting @@ -553,7 +553,7 @@ def ellipse_to_plot(self, xcen, ycen, pixscale): height=(self.minor.to(u.deg) / pixscale).to(u.dimensionless_unscaled).value, # PA is 90 deg offset from x-y axes by convention # (it is angle from NCP) - angle=(self.pa+90*u.deg).to(u.deg).value) + angle=(self.pa+90*u.deg).to(u.deg).value, **kwargs) def as_kernel(self, pixscale, **kwargs): """