Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logrotate_app works only for upstart #550

Open
vladzu opened this issue Mar 13, 2020 · 4 comments
Open

logrotate_app works only for upstart #550

vladzu opened this issue Mar 13, 2020 · 4 comments

Comments

@vladzu
Copy link

vladzu commented Mar 13, 2020

Why logrotate is configured only for upstart ?

if node['rabbitmq']['job_control'] == 'upstart' && node['rabbitmq']['manage_service']
...
logrotate_app 'rabbitmq-server' do
path node['rabbitmq']['logrotate']['path']
enable node['rabbitmq']['logrotate']['enable']
rotate node['rabbitmq']['logrotate']['rotate']
frequency node['rabbitmq']['logrotate']['frequency']
options node['rabbitmq']['logrotate']['options']
sharedscripts node['rabbitmq']['logrotate']['sharedscripts']
postrotate node['rabbitmq']['logrotate']['postrotate']
end

why this is like that ? and why not to use it for systemd OS's?

@michaelklishin
Copy link
Member

michaelklishin commented Mar 14, 2020 via email

@fozboz
Copy link
Contributor

fozboz commented Dec 17, 2022

@michaelklishin What do you think to removing all of the logrotate stuff altogether? IMO a rabbitmq cookbook should install and configure rabbitmq and nothing else.

@lukebakken
Copy link
Contributor

@fozboz makes sense to me. Feel free to open a PR

@michaelklishin
Copy link
Member

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants