Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOTI tutorial CUDA_HOME #3153

Open
bhack opened this issue Nov 6, 2024 · 8 comments
Open

AOTI tutorial CUDA_HOME #3153

bhack opened this issue Nov 6, 2024 · 8 comments
Labels
triaged Issues has been triaged

Comments

@bhack
Copy link

bhack commented Nov 6, 2024

📚 The doc issue

I am trying to follow https://pytorch.org/tutorials/recipes/torch_export_aoti_python.html but it seems it doesn't work on our nightly runtime images cause missing CUDA_HOME.

Suggest a potential alternative/fix

No response

cc @svekars @brycebortree @sekyondaMeta @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4 @desertfire @chenyang78

@bhack
Copy link
Author

bhack commented Nov 6, 2024

/cc @agunapal @angelayi @svekars it is working only with devel image

@agunapal
Copy link
Contributor

agunapal commented Nov 7, 2024

Hi @bhack I believe that is correct. Generation of the .so requires a devel image. That was my observation too when I tried it few months ago.

@bhack
Copy link
Author

bhack commented Nov 7, 2024

Is this what we want? If yes do we want to document it?

@agunapal
Copy link
Contributor

agunapal commented Nov 7, 2024

Will update the tutorial once pytorch/pytorch#140055 and pytorch/pytorch#140053 are resolved. This likely already works in the nightlies

@bdhirsh bdhirsh added the triaged Issues has been triaged label Nov 8, 2024
@svekars svekars transferred this issue from pytorch/pytorch Nov 8, 2024
@bhack
Copy link
Author

bhack commented Dec 3, 2024

Any update?

@agunapal
Copy link
Contributor

agunapal commented Dec 3, 2024

@bhack i will update the tutorial for PT 2.6

@bhack
Copy link
Author

bhack commented Dec 3, 2024

@agunapal I am adding g++ in runtime images with pytorch/pytorch#138612 to solve pytorch/pytorch#116696 (torch.compile) but I suppose that it is not enough for you export. What do you think?

@agunapal
Copy link
Contributor

agunapal commented Dec 3, 2024

Yes, I will mention in the updated tutorial that you need a devel image to create .pt2 package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issues has been triaged
Projects
None yet
Development

No branches or pull requests

3 participants