Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move update_recipe_state to its own util #2158

Open
joecummings opened this issue Dec 13, 2024 · 4 comments
Open

Move update_recipe_state to its own util #2158

joecummings opened this issue Dec 13, 2024 · 4 comments
Labels
best practice Things we should be doing but aren't triaged This issue has been assigned an owner and appropriate label

Comments

@joecummings
Copy link
Contributor

I'm tired of looking at it.
@joecummings joecummings added triaged This issue has been assigned an owner and appropriate label best practice Things we should be doing but aren't labels Dec 13, 2024
@krammnic
Copy link
Contributor

Will open PR, but where to locate it? In dev?

@krammnic
Copy link
Contributor

@joecummings Hey! Can you give some insights about this question please?

Will open PR, but where to locate it? In dev?

@joecummings
Copy link
Contributor Author

Hey @krammnic - I really appreciate you reaching out to work on this; however, I really made it as a note for me to take a look at, which I promise I will soon.

I think it'll be complicated b/c I'm planning large changes to how we do checkpointing in torchtune, therefore recipe state will likely change.

@krammnic
Copy link
Contributor

No problem! Ping me if some help will required ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Things we should be doing but aren't triaged This issue has been assigned an owner and appropriate label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joecummings @krammnic