Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobConfig does not support typing #753

Open
greeneggsandyaml opened this issue Dec 18, 2024 · 1 comment
Open

JobConfig does not support typing #753

greeneggsandyaml opened this issue Dec 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@greeneggsandyaml
Copy link

Hello authors, thank you for your very nice repo! I love how clean and minimal it is.

The JobConfig class does not support typing at the moment, which is frustrating. Would you consider a contribution to change the JobConfig class to support typing?

I just wanted to ask before doing and contributing it.

All the best,
greeneggsandyaml
@fegin
Copy link
Contributor

fegin commented Dec 18, 2024

We always welcome any contribution and you can read CONTRIBUTING.md for more details.

@tianyu-l tianyu-l added the enhancement New feature or request label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fegin @greeneggsandyaml @tianyu-l