Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create doc and tests for distributed inference #1358

Open
mikekgfb opened this issue Nov 8, 2024 · 1 comment
Open

Create doc and tests for distributed inference #1358

mikekgfb opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
actionable Items in the backlog waiting for an appropriate impl/fix Distributed Issues related to all things distributed documentation Improvements or additions to documentation triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@mikekgfb
Copy link
Contributor

mikekgfb commented Nov 8, 2024

🚀 The feature, motivation and pitch

Once distributed inference integration into torchchat is functional, let's add a docs/distributed.md with an example, and plumb that example into .ci/scripts/run-docs distributed. (updown.py extracts all commands between triple backticks into a test script.)

torchchat has the same runners as pytorch/pytorch, so at least a minimal 2 or 4 GPU setup on a single node would be great. Not sure whether we can run multi-node testing, you can suppress commands from tests with [skip default]: begin and [skip default]: end around those commands.

cc: @mreso @lessw2020 @kwen2501

Alternatives

None

Additional context

No response

RFC (Optional)

No response

@Jack-Khuu Jack-Khuu added documentation Improvements or additions to documentation actionable Items in the backlog waiting for an appropriate impl/fix Distributed Issues related to all things distributed labels Nov 12, 2024
@Jack-Khuu
Copy link
Contributor

Definitely something we plan to add!

@Jack-Khuu Jack-Khuu added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable Items in the backlog waiting for an appropriate impl/fix Distributed Issues related to all things distributed documentation Improvements or additions to documentation triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

3 participants