Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump numpy version in torchchat to match that of PyTorch #1321

Open
Jack-Khuu opened this issue Oct 21, 2024 · 1 comment
Open

Bump numpy version in torchchat to match that of PyTorch #1321

Jack-Khuu opened this issue Oct 21, 2024 · 1 comment
Labels
actionable Items in the backlog waiting for an appropriate impl/fix enhancement New feature or request Known Gaps These are known Gaps/Issues/Bug items in torchchat

Comments

@Jack-Khuu
Copy link
Contributor

Jack-Khuu commented Oct 21, 2024 •
edited
Loading

🚀 The feature, motivation and pitch

Currently torchchat uses a restricted numpy version

torchchat/install/requirements.txt

Line 16 in 0e37b9a

numpy >= 1.17, < 2.0
due to a dependency on gguf-py (https://github.com/ggerganov/llama.cpp/blob/master/gguf-py/pyproject.toml).

We should move to matching the same numpy requirements as pytorch/pytorch. This allows for better continuity across repos.

https://github.com/pytorch/pytorch/blame/main/requirements.txt#L5

To do so, we must first bump the gguf-py requirements, then bump the torchchat requirements

Alternatives

No response

Additional context

No response

RFC (Optional)

No response
@Jack-Khuu Jack-Khuu added enhancement New feature or request Known Gaps These are known Gaps/Issues/Bug items in torchchat actionable Items in the backlog waiting for an appropriate impl/fix labels Oct 21, 2024
@Jack-Khuu
Copy link
Contributor Author

Related initial attempt: #1296

  • reverted due to GGUF dep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Items in the backlog waiting for an appropriate impl/fix enhancement New feature or request Known Gaps These are known Gaps/Issues/Bug items in torchchat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jack-Khuu