Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Pull Request】Adapting to a new Torch profiling data #964

Open
Wuyulongpro opened this issue Jul 23, 2024 · 0 comments
Open

【Pull Request】Adapting to a new Torch profiling data #964

Wuyulongpro opened this issue Jul 23, 2024 · 0 comments
Labels
plugin PyTorch Profiler TensorBoard Plugin related

Comments

@Wuyulongpro
Copy link

Thank you very much for developing this tool, which is a great convenience for the visualization of model performance tuning. We have optimization data collected by the torch framework running based on the new AI chip architecture. This data format is different from xxx.pt.trace.json. It is a directory. However, the views displayed on the Tensorboard is the same. Therefore, some data adaptations are performed, including:
1. Verify the file/directory name rule.
2. Some new data reading methods are added. (In addition to JSON files, CSV files are read.)
3. Modified some functions and classes.
The preceding operations are only compatible with the new data format and have no impact on the original data parsing mode. Currently, the fronted web pages use Google Charts, which depends on the network. To ensure that tool can be used offline, the following modifications are made:
1. Replaced Google Charts with echarts. (Echarts line charts have better performance in big data scenarios.)
2. In the new data format, some views (such as Kernel and Memory) are modified, but the original data display is not affected.
3. The webcomponents.min.js file imported in trace_embedding.html is downloaded offline as a local static file.
Do you still accept pull request? The code changes are about 2k lines.

@sraikund16 sraikund16 added the plugin PyTorch Profiler TensorBoard Plugin related label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin PyTorch Profiler TensorBoard Plugin related
Projects
None yet
Development

No branches or pull requests

2 participants