Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about how to run "make test" correctly? #864

Open
PriscillaJCorn opened this issue Feb 6, 2024 · 2 comments
Open

Question about how to run "make test" correctly? #864

PriscillaJCorn opened this issue Feb 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@PriscillaJCorn
Copy link

PriscillaJCorn commented Feb 6, 2024

Hi guys,
Follow the steps in README.md, I have succeed to build Libkineto. Then, I start to run the tests with the command "make test", but it doesn't change anything. In this CMakeLists.txt file, it seems like that you just add the test folder in this project but do not build anything, so I am very confused about how to "make test" and what is the meanning of

(if tests are built)

Anyway... Could somebody tell me how to build and run the code in the test folder? Thanks

@aaronenyeshi
Copy link
Member

Hi, sorry about this, our README may be outdated. Currently our tests are run internally, and the CMakeLists.txt for our tests directory is incomplete: https://github.com/pytorch/kineto/blob/main/libkineto/test/CMakeLists.txt#L6.

We are open to the open source contributions to get this running in OSS. Currently the Github CI only builds libkineto, but does not test it, would be great to get Github CI running tests too. https://github.com/pytorch/kineto/blob/main/.github/workflows/libkineto_ci.yml#L56

@aaronenyeshi aaronenyeshi added the enhancement New feature or request label Feb 9, 2024
@aaronenyeshi
Copy link
Member

This is a duplicate of #803

@aaronenyeshi aaronenyeshi added bug Something isn't working and removed enhancement New feature or request labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants