New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] More code-reuse across tests #1869

Open

atalman opened this issue Jun 17, 2024 · 1 comment

Contributor

atalman commented Jun 17, 2024 •

edited by malfet

Loading

Previous title: ~~Enable check_binary for MacOS and Windows~~
MacOS and Windows nightly builds are missing check_binary.sh step:

See reference issue: pytorch/pytorch#120995

Linux builds has check_binary: https://github.com/pytorch/pytorch/actions/runs/9543726459/job/26305659019#step:17:308
However not macos or Windows.
For faster development. We can try to enable check binary running on Validation tests here:
https://github.com/pytorch/builder/blob/main/.github/scripts/validate_binaries.sh#L54

When successful we can later move it our CI

atalman added this to PyTorch OSS Release Engineering

atalman converted this from a draft issue

atalman changed the title ~~Re-enable check_binary for all nightly builds~~ Enable check_binary for MacOS and Windows

Contributor

malfet commented Jun 17, 2024

I think title of this issue is somewhat misleading, as check_binary is already invoked for MacOS builds:
https://github.com/pytorch/pytorch/blob/0f89e66d1745b8f4b304ebf46174bc726f0c28f5/.circleci/scripts/binary_macos_test.sh#L30

malfet changed the title ~~Enable check_binary for MacOS and Windows~~ [BE] More code-reuse across tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment