Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow negative indices to fixed_features in optimizers #2605

Open
esantorella opened this issue Oct 31, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@esantorella
Copy link
Member

🚀 Feature Request

Allow negative indices to fixed_features and fixed_features_list in optimizers such as optimize_acqf

Motivation

This came up in #2602. It is tempting to describe the index of a feature with an index like "-1", but this is not currently supported.

Pitch

This should be easy to do by changing the indices to index % num_features.

Are you willing to open a pull request? (See CONTRIBUTING)

Only if users want this! Speak up if this would be useful for you (or would have spared your past self some hassle).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant