Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fine-grained documentation needed for torchao.autoquant() #907

Open
suvadityamuk opened this issue Sep 19, 2024 · 3 comments
Open

More fine-grained documentation needed for torchao.autoquant() #907

suvadityamuk opened this issue Sep 19, 2024 · 3 comments
Assignees

Comments

@suvadityamuk
Copy link

There is an important need for better documentation of options, features, and args for torchao.autoquant() along with some important gotchas, i.e. around the error_on_unseen flag among others.

@jerryzh168
Copy link
Contributor

cc @HDCharles can you take a look

maybe adding error_on_unseen to the official list of args:

def autoquant(
would be helpful

@jerryzh168
Copy link
Contributor

@suvadityamuk please let us know if you'd like to work on this as well, also it would be helpful if you can provide a bit more detail on what the existing doc is missing as well, apart from error_on_unseen

@suvadityamuk
Copy link
Author

@suvadityamuk please let us know if you'd like to work on this as well, also it would be helpful if you can provide a bit more detail on what the existing doc is missing as well, apart from error_on_unseen

Yeah sure, happy to work on this. I'll try to go and check again further about what is missing as well.

cc: @msaroufim We spoke today at the PyTorch Conference about this. Let me know any next steps about this as well, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants