Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmaintained flake8-noqa, Adding support for external codes #13296

Open
Avasam opened this issue Dec 24, 2024 · 0 comments
Open

Unmaintained flake8-noqa, Adding support for external codes #13296

Avasam opened this issue Dec 24, 2024 · 0 comments
Labels
project: infrastructure typeshed build, test, documentation, or distribution related status: needs decision Needs a final decision by the typeshed maintainers

Comments

@Avasam
Copy link
Collaborator

Avasam commented Dec 24, 2024

About a year ago, I opened a PR to add support recognizing external codes to flake8-noqa, complete with unit tests (plinss/flake8-noqa#30), to achieve the same feature as

typeshed/pyproject.toml

Lines 36 to 38 in e5c5318

# We still use flake8-pyi and flake8-noqa to check these (see .flake8 config file);
# tell ruff not to flag these as e.g. "unused noqa comments"
external = ["F821", "NQA", "Y"]
with the goal of addressing this issue:

typeshed/pyproject.toml

Lines 49 to 51 in e5c5318

# PYI: only enable rules that have autofixes and that we always want to fix (even manually),
# avoids duplicate # noqa with flake8-pyi and flake8-noqa flagging `PYI` codes
# See https://github.com/plinss/flake8-noqa/issues/22

However, here we are, a year later, with no news from the maintainer despite some attempts at contacting outside GitHub through official email. Peter Linss is still active at w3ctag, leaving me under the impression that the project is currently unmaintained, and wondering if we could instead use a fork based on the feature I added. Either by pointing at a GitHub branch or release in our requirements file, or by publishing a fork on PyPI under the python/typeshed or PyCQA umbrella.

@Avasam Avasam added project: infrastructure typeshed build, test, documentation, or distribution related status: needs decision Needs a final decision by the typeshed maintainers labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: infrastructure typeshed build, test, documentation, or distribution related status: needs decision Needs a final decision by the typeshed maintainers
Projects
None yet
Development

No branches or pull requests

1 participant