From 6bf865934bfec1ea2c7200f3fd6195f11666827d Mon Sep 17 00:00:00 2001 From: Luke Atkinson Date: Tue, 2 Jan 2024 16:49:32 +0000 Subject: [PATCH] Fix invalid PrometheusRule when adding grouping to a ratio indicator --- kubernetes/controllers/servicelevelobjective.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kubernetes/controllers/servicelevelobjective.go b/kubernetes/controllers/servicelevelobjective.go index 46f6a2cc..18c9902c 100644 --- a/kubernetes/controllers/servicelevelobjective.go +++ b/kubernetes/controllers/servicelevelobjective.go @@ -180,9 +180,9 @@ func makeConfigMap(name string, kubeObjective pyrrav1alpha1.ServiceLevelObjectiv return nil, fmt.Errorf("failed to get generic rules: %w", err) } // ignore these rules + } else { + rule.Groups = append(rule.Groups, rules) } - - rule.Groups = append(rule.Groups, rules) } bytes, err := yaml.Marshal(rule) @@ -244,9 +244,9 @@ func makePrometheusRule(kubeObjective pyrrav1alpha1.ServiceLevelObjective, gener return nil, fmt.Errorf("failed to get generic rules: %w", err) } // ignore these rules + } else { + rule.Groups = append(rule.Groups, rules) } - - rule.Groups = append(rule.Groups, rules) } isController := true