You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently this fetches the distribution from PyPI into a BytesIO object, after doing a requests.get() call (not streaming).
That means that while we're inside of _get_dist, we'll currently be using 2x the file size of the distribution worth of extra RAM, and outside of it we'll be using 1x the file size of extra RAM.
This should probably buffer to a temporary file and use streaming requests so that a large distribution doesn't kill us on memory.
This might just be #5 but I wanted to call it out explicitly since this applies even if we're storing the files somewhere.
The text was updated successfully, but these errors were encountered:
Currently this fetches the distribution from PyPI into a
BytesIO
object, after doing arequests.get()
call (not streaming).That means that while we're inside of
_get_dist
, we'll currently be using 2x the file size of the distribution worth of extra RAM, and outside of it we'll be using 1x the file size of extra RAM.This should probably buffer to a temporary file and use streaming requests so that a large distribution doesn't kill us on memory.
This might just be #5 but I wanted to call it out explicitly since this applies even if we're storing the files somewhere.
The text was updated successfully, but these errors were encountered: