Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Requires MongoDB, Doesn't provide other DB support. #28

Open
duaneking opened this issue Oct 26, 2017 · 0 comments
Open

Project Requires MongoDB, Doesn't provide other DB support. #28

duaneking opened this issue Oct 26, 2017 · 0 comments

Comments

@duaneking
Copy link

This project looked really interesting until I read the words "mongodb". This is a blocker for me, but there is a greater issue that is actually worth reporting so here so I am:

The code is lacking a separation of concerns around data storage and usage. Looking at the code, this does seem to be the case.

The current interface is all static methods with no DB context or abstraction layer to allow other databases be used for data storage... so we cant even test if it actually works - as it a common need with oauth libs - without first setting up a MongoDB instance, and since MongoDB instances are a poison (its the wrong tool for the job 100% of the time due to its eventual consistency model, the a=inability to fail and recover gracefully, and lack of pure ACID support) nobody wants to do that.

Please support other databases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant