Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate encoder= calling parameter in all APIs #532

Open
6 tasks
lmctv opened this issue May 18, 2019 · 1 comment
Open
6 tasks

Deprecate encoder= calling parameter in all APIs #532

lmctv opened this issue May 18, 2019 · 1 comment

Comments

@lmctv
Copy link
Contributor

lmctv commented May 18, 2019

The encoder= parameter in our API leads to some confusing bugs like #525; if we remove all its usages, we'll be able to remove the nacl.encodings module which just duplicates functionality already present in the standard library.
The involved modules are:

  • signing
  • public
  • secret
  • hash
  • pwhash
  • encoding
@lmctv lmctv mentioned this issue May 18, 2019
Closed
@lmctv
Copy link
Contributor Author

lmctv commented Jun 5, 2019

@reaperhulk @pyca/pynacl-core I'm thinking a possible way forward could be to postpone #523 and release 1.4. In this case, I'd just like to add some notes about the pending deprecation of the encoder parameter in the docs before the release.

Samyak2 added a commit to Samyak2/block-chat that referenced this issue Jun 30, 2020
@Samyak2
Store transactions in Firebase DB, removed usage of nacl.encoding
48fd351 
 - Using bytes.from_hex and bytes.hex instead of nacl.encoding since it is
   planned to be made deprecated
   (pyca/pynacl#532)
 - Unconfirmed transactions are now stored in the firebase realtime database
   since using in-memory variables in cloud run does not guarantee safety.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmctv