Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all arguments in NodeGroupV2 to be pulumi.Input #1274

Open
Makeshift opened this issue Jul 23, 2024 · 5 comments
Open

Allow all arguments in NodeGroupV2 to be pulumi.Input #1274

Makeshift opened this issue Jul 23, 2024 · 5 comments
Assignees
@flostadler
Labels
impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features

Comments

@Makeshift
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

I ran into an issue today when trying to create a NodeGroup whose labels and taints were not known initially and were therefore pulumi.Output's. Unfortunately, the labels and taints args (and a few more) in the NodeGroupV2 component are treated and typed as plain values, so it isn't possible to use potentially-unresolved values when creating them.

Please add support for labels and taints to be resolved from pulumi.Output.

Affected area/feature

This component.
@Makeshift Makeshift added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jul 23, 2024
@Makeshift
Copy link
Author

As an aside, I did try to do this myself so I could PR it, but unfortunately hit some serialisation issues that I'm not familiar enough with to debug effectively.

@t0yv0 t0yv0 added impact/breaking Fixing this issue will require a breaking change and removed needs-triage Needs attention from the triage team labels Jul 25, 2024
@t0yv0
Copy link
Member

t0yv0 commented Jul 25, 2024

Thank you for trying to send a PR here! Unfortunately it's a little more involved. Our team will have a look at this when planning the next major release, possibly combined with #603

@t0yv0
Copy link
Member

t0yv0 commented Jul 25, 2024

CC @flostadler

@flostadler flostadler mentioned this issue Oct 2, 2024
Merged
flostadler added a commit that referenced this issue Oct 2, 2024
@flostadler
Change arguments of NodeGroup & NodeGroupV2 to accept inputs (#1415)
ea15764 
Historically the following `NodeGroup` & `NodeGroupV2` input properties
have been plain:
- `kubeletExtraArgs`
- `bootstrapExtraArgs`
- `labels`
- `taints`
- `nodeAssociatePublicIpAddress`

Those should instead be inputs so users can pass outputs into them.

fixes #1274
@flostadler
Copy link
Contributor

We've addressed this as part of #1415. This will be released with EKS v3

@flostadler flostadler self-assigned this Oct 4, 2024
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/3558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flostadler flostadler

Labels
impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features
Projects
[Epic] EKS Modernization
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@t0yv0 @Makeshift @flostadler @cleverguy25