Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming test_nodejs_upgrade Make targets and GitHub actions #1257

Open
t0yv0 opened this issue Jul 16, 2024 · 0 comments
Open

Consider renaming test_nodejs_upgrade Make targets and GitHub actions #1257

t0yv0 opened this issue Jul 16, 2024 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Jul 16, 2024

Tests under provider/* are not necessarily confined to testing provider upgrade scenarios, but can contain other tests that exercise the provider but provide no added value as examples. The ask here is to consider renaming test_nodejs_upgrade Make target and associated GitHub Action labels to be more inclusive to non-upgrade tests.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Jul 16, 2024
@t0yv0 t0yv0 mentioned this issue Jul 16, 2024
Merged
@mjeffryes mjeffryes added the kind/engineering Work that is not visible to an external user label Jul 16, 2024
@corymhall corymhall removed the needs-triage Needs attention from the triage team label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@t0yv0 @mjeffryes @pulumi-bot @corymhall