Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi convert --from terraform should error if there are no terraform files to convert. #173

Open
guineveresaenger opened this issue Jul 18, 2024 · 0 comments
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec

Comments

@guineveresaenger
Copy link

What happened?

Working in the bridge using temp dirs to generate some example code, I was in the incorrect directory running pulumi convert. The command succeeded. It should have errored out with "no Terrafrom files to convert". Took me entirely too long to realize what was happening.

The convert tool should let the user know about missing input.

Example

guin /Users/guin🦉 mkdir convert
guin /Users/guin🦉 cd convert
guin guin/convert🦉 ls
guin guin/convert🦉 pulumi convert --from terraform --language pcl
Converting from terraform...
Converting to pcl...
guin guin/convert🦉 ls                                            
guin guin/convert🦉 

Output of pulumi about

guin guin/convert🦉 pulumi about
CLI          
Version      3.116.1
Go Version   go1.22.3
Go Compiler  gc

Host     
OS       darwin
Version  13.5
Arch     arm64

Backend        
Name           pulumi.com
URL            https://app.pulumi.com/guinevere-pulumi-corp
User           guinevere-pulumi-corp
Organizations  guinevere-pulumi-corp, pulumi
Token type     personal

Pulumi locates its logs in /var/folders/87/6b426tw97kl6vb55pl6nbzym0000gn/T/ by default

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@guineveresaenger guineveresaenger added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jul 18, 2024
@Frassle Frassle transferred this issue from pulumi/pulumi Jul 18, 2024
@Frassle Frassle added impact/usability Something that impacts users' ability to use the product easily and intuitively and removed needs-triage Needs attention from the triage team labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants