Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: What AWS permissions should PDC files have? #1954

Open
2 of 4 tasks
bess opened this issue Sep 30, 2024 · 1 comment
Open
2 of 4 tasks

SPIKE: What AWS permissions should PDC files have? #1954

bess opened this issue Sep 30, 2024 · 1 comment

Comments

@bess
Copy link
Contributor

bess commented Sep 30, 2024

User story

As an organization that runs a trusted digital repository, I want to ensure that files can't be deleted by unauthorized users, and can't easily be deleted accidentally. However, on 30 September 2024 the team learned that our checksum files had been deleted. They were deleted more than 30 days ago, so we cannot restore them. We do not have any record of who deleted them or why, and we have no reason to think this can't happen again. Also, if this can happen to our checksum files, we think it could also happen to actual research data.

Acceptance criteria

  • Investigate and document what AWS user owns the files right now, and what ACLs are attached to those files
  • Is it currently the case that any PUL AWS user could delete PUL files?
  • If so, what ACLs should we be putting into place to ensure that only authorized users can delete files?
  • Document all of this and give it to Kate
@bess
Copy link
Contributor Author

bess commented Oct 2, 2024

  1. The owner of the PDC files is aws-0003
    Screenshot 2024-10-02 at 2 09 35 PM

  2. The owner of all of the other files I checked is also aws-0003
    Screenshot 2024-10-02 at 2 12 38 PM

  3. Since all files have the same owner, and that owner can read and write their own files, I believe that anyone who can authenticate to the pulibrary AWS account can delete PDC files or buckets.
    Screenshot 2024-10-02 at 2 14 45 PM

  4. To fix this, we need to set permissions policy at the bucket level. Currently, there is no ACL policy in place.
    Screenshot 2024-10-02 at 2 17 38 PM

@bess bess self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant