Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking Visual/Audio settings sliders on beatmap loading will keep them selected permanently #30716

Open
imvanni opened this issue Nov 17, 2024 · 6 comments · May be fixed by #30799
Open

Clicking Visual/Audio settings sliders on beatmap loading will keep them selected permanently #30716

imvanni opened this issue Nov 17, 2024 · 6 comments · May be fixed by #30799
Assignees
@peppy
Labels
area:settings priority:0 Showstopper. Critical to the next release. type:behavioural

Comments

@imvanni
Copy link

imvanni commented Nov 17, 2024 •
edited
Loading

Type

Game behaviour

Bug description

Tapping any slider (this also applies to drag begin) on settings while the beatmap is loading will keep that slider selected, prompting the map to not load until it is unselected. While it is not game breaking, it is quite annoying sometimes.

Previously, moving the sliders would not keep them in a "selected" state.

Screenshots or videos

image

Version

2024.1115.3

Logs

compressed-logs.zip
@shinmorisawa
Copy link
Contributor

i think this is intentional. idk though

@smoogipoo
Copy link
Contributor

This is indeed intentional.

@peppy
Copy link
Member

peppy commented Nov 18, 2024

prompting the map to not load until it is unselected. While it is not game breaking, it is quite annoying sometimes.

i'm not sure this should be closed if the OP is correct.

@smoogipoo
Copy link
Contributor

Ah, I missed that part. I agree.

@smoogipoo smoogipoo reopened this Nov 18, 2024
@imvanni
Copy link
Author

imvanni commented Nov 18, 2024

Should've attached a video to this earlier.

2024-11-18_12-01-14.mp4

@imvanni
Copy link
Author

imvanni commented Nov 18, 2024 •
edited
Loading

Not load as in not start? Did I use the wrong wording back there? I don't know. I'm pretty sure I did, because the map does "load".

If what's on the video is supposed to be intentional behavior, then we can close it. Though I preferred the old behavior.

@peppy peppy added priority:0 Showstopper. Critical to the next release. type:behavioural and removed type:cosmetic labels Nov 18, 2024
@peppy peppy self-assigned this Nov 20, 2024
peppy added a commit to peppy/osu that referenced this issue Nov 20, 2024
@peppy
Fix beatmap load not continuing when when settings slider is focused
ae98f63 
Regressed with recent sliderbar focus changes.

Closes ppy#30716.
@peppy peppy linked a pull request Nov 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppy peppy

Labels
area:settings priority:0 Showstopper. Critical to the next release. type:behavioural
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix beatmap load not continuing when when settings slider is focused peppy/osu
4 participants
@peppy @smoogipoo @imvanni @shinmorisawa