-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmarked featured artist maps #8111
Comments
No changes have been made to the initial implementation yet. So it can be expected that no changes have been made yet. Please wait a bit longer for this to happen. Featured artist beatmaps are sourced from ground truth .osz files. Metadata of beatmaps should match them. As long as this matches there should be no issue. If you are to report issues for now, I'd recommend reporting issues with the template files. For now, to keep traffic low, please keep reports to issues with the templates or listings. |
The osz files? That doesn't seem right, dozens of items in the list already match the FA osz templates but aren't marked. See for example the Aitsuki Nakuru maps or the Loki / Thaehan maps. Is there some place to track the status in terms of waiting? |
Let me try again: For now, please only report issues with the listing or templates rather than beatmaps. These are not yet being used, but that is considered the source of ground truth which will be used going forward. Tracking waiting can be done by looking at my (private) todo list. So unfortunately not, but I have the task scheduled for this weekend. |
An initial pass has been made to catch the more common issues (1752 -> 2168 for ranked/loved). I haven't gone through your spreadsheet yet, but it'd be appreciated if you can update it as above (listing any FA-side issues) and maybe a bullet point list of any remaining common failure cases (with one beatmap example max). No need for huge lists. |
Full list of maps found so far which match the template and are unmarked: reference I'm mainly linking this because the reasons why they're unmarked is just guess work and would need further investigation.. I'm working with eiri- to compile FA osz template issues for later, but these are some common cases with already matching map and template which were noticed. |
Ah, case sensitivity was one on my list I completely forgot to apply. That's added an additional couple of hundred mappings (have re-run since). The metadata issues you point out so fare are going to be resolved in a pass we need to do of some older artists where osz don't match databased metadata. |
I've added some better handling when .osz doesn't match database, should have caught a lot of the edge cases you mentioned above. 37 new tracks matched. |
hi, I found a false positive that's related to the FA tag: https://osu.ppy.sh/beatmapsets/373414#taiko/818079 pretty sure toby fox isn't a featured artist, and clicking the tag sends you to Camellia's FA page |
Thanks, will add a rule against matching on remixes like that (camellia has a remix of that track) |
All of the issues mentioned in #8111 (comment) have been resolved. Let me know if you find any more. |
false positive : https://osu.ppy.sh/beatmapsets/1329045#osu/2753127 the remix of this song isn't on the FA |
Thanks, I've unmarked that beatmap and adjusted the rules to better handle remixes (again). |
Found a couple of missing MIMI sets for "Nanimo Nai Youna". Based on beatmapset discussion, seems to be a romanization error on the osz/listing, which reads "Nani mo Nai Youna" (with an additional space): https://osu.ppy.sh/beatmapsets/1151466/discussion/-/generalAll#/1557587 https://osu.ppy.sh/beatmapsets/1151466 |
@peppy would like to report some potential cases of false positives that i found regarding the song "Yuyoyuppe - Palette" :
this version of the song is an utaite cover of the original vocaloid version (which is licensed), yet somehow it is still tagged as "Featured Artist" in the website. not sure if this is intended behaviour or not tho
...yeah, i'm pretty sure this one is just a (fanmade?) speed up edit of the song of some sort and by any means not official ;~; |
None of the maps that appear in rejection's news post are actually marked as featured artist maps. All are of the same song, "Signal feat. Such" which appears to be licensed:
Also, can we get confirmation that the detection is run automatically after a new artist is announced? Like how long should we wait to report issues with new artists? |
You should not report issues for new artists. That's out of scope of this thread. Please read my previous comments on what should be posted in this thread. |
In addition to the ones Niva mentioned, for ones that are falsely flagged or unflagged
https://osu.ppy.sh/beatmapsets/12731#osu/47535 I'm not sure of the current methodology but I think it could work like
It seems like current matching still misses quite a few things and also picks up other remixes and alternate vocal versions incorrectly. |
No fix has been applied yet for issues I have not replied to as resolved. Please be patient. No need to attempt to define how the process works as I have that under control. |
couple songs didn't get marked that i mapped: united laos remix https://osu.ppy.sh/beatmapsets/1323369#taiko/2741231 algebra https://osu.ppy.sh/beatmapsets/1285922#taiko/2670153 |
Graveyard is out of scope right now. |
Another false positive same song as #8111 (comment) |
I honestly think these kinds of edge cases are fine to leave as is. The artist is featured and the tracks are the correct (base) tracks. The main purpose here is providing visibility, not a perfect 1:1 match. So I'm going to leave these for now. |
I've done another update covering hopefully all the issues posted above. Also found around 100 new (ranked) beatmaps in the process. Please resurface any I may have missed! |
@NoffyNoffeh can i assume that silence here means that things are in a good state, or have you just not had a chance to do another pass? |
well uh, you still haven't unmarked the glacierfall remix map i linked |
hi, missing FA marker here: |
https://osu.ppy.sh/beatmapsets/1885318 |
https://osu.ppy.sh/beatmapsets/96580#osu/258816 |
Missing FA marker/incorrect FA listing metadata: Map metadata spells title Metadata sources linked in map discussion: |
https://osu.ppy.sh/beatmapsets/682598#taiko/1443524 Missing FA mark because the title in FA listing is wrong. |
https://osu.ppy.sh/beatmapsets/2079507 dreaming from twin trials contest has mismatching metadata |
https://osu.ppy.sh/beatmapsets/2024359 False positive marked as FA |
^ same with https://osu.ppy.sh/beatmapsets/96580 |
https://osu.ppy.sh/beatmapsets/2116675#osu/4448144 |
missing the fa marker https://osu.ppy.sh/beatmapsets/1972749#osu/4093503 the template osz was updated after the first map was ranked, so that may be related |
Also missing the FA marker:
|
https://osu.ppy.sh/beatmapsets/2155736#osu/4544081 unmarked Fa tag |
https://osu.ppy.sh/beatmapsets/1885318#osu/4127309 seems to be false positive as the song isn't available under FA listing |
https://osu.ppy.sh/beatmapsets/2079919#osu/4520026 another false positive (artist has a licensed song called "Moai") |
https://osu.ppy.sh/beatmapsets/1151089 unmarked, linked in DGK showcase |
https://osu.ppy.sh/beatmapsets/2162219#mania/4559801 The song “rabbit in the black room”is in the fa listing, but there is a remaster ver called “rabbit in the black room(2023 VIP),i havent see this remaster ver in the fa listing but it has fa marked in the information page |
https://osu.ppy.sh/beatmapsets/2199195#taiko/4662115 falsely marked as FA because of Silentroom - Angel Echo existing |
https://osu.ppy.sh/beatmapsets/2203526#taiko/4664066 Missing FA marker, but https://osu.ppy.sh/beatmapsets/1929063#mania/3984270 has it with the same metadata. |
I've noticed recently that due to the Ranking Criteria's standardization for metadata, certain tracks do not obtain the Featured Artist website tag like they should. A example of this (which was recently fixed) is "ELFENSJoN - Hyousou wa Hakuen o Matoite", which was originally "ELFENSJoN - Hyousou wa Hakuen wo Matoite" (Ranking Criteria standardizes "wo" to "o" in romanisation) Another example has popped up, being "uma vs. Morimori Atsushi - Re:End of a Dream" and "uma vs. Morimori Atsushi - Re:End of a Dream (long ver.)" which Ranking Criteria standardizes to "uma vs. Morimori Atsushi - Re: End of a Dream (long ver.)" and "uma vs. Morimori Atsushi - Re: End of a Dream". One more example is "Papercut - Come Home (ft. Sylvia Bremer)" which would be standardized to "Papercut - Come Home (feat. Sylvia Bremer)" |
https://osu.ppy.sh/beatmapsets/421554#osu/4303937 |
https://osu.ppy.sh/beatmapsets/1175640#osu/2452076
|
https://osu.ppy.sh/beatmapsets/2214653#taiko/4692536 N.M.W KINEMA106 unmarked Fa marker |
https://osu.ppy.sh/beatmapsets/1795159 |
The following two tracks seem to be incorrectly translated in the FA page. Doesn't seem to be a issue with the "feat." part because "Camellia feat. Nanahira - Kizuitara Shunkashuutou" are marked correctly. Mapset name: Camellia feat. Nanahira - Energy * Drin-ko Fein-chan! Mapsets name: Camellia feat. Nanahira - Energy * Drin-ko Fein-chan! (Camellia's "MONSTERISTIC" D. M. P. Remix) |
(quotes from #8111 (comment))
When ppy/osu#31238 goes in, the featured artist badge is going to be more important.
The ranking criteria require FA maps to be marked with How hard is it to change tags on already uploaded beatmapsets? |
Do note that for a long time the |
It's been a week and from what I recall, we were asked to wait a week before reporting on unmarked FA maps. So here's a list?
google sheet
This list covers 499 ranked and loved maps of featured artist tracks which are not marked as featured artist on the website. I arbitrarily stopped at 499, this list is not fully comprehensive of all unmarked maps. I estimate over a third of all Featured Artist maps of licensed tracks are unmarked.
For tracks with multiple FAs I list only the first. Not sure how this is handled otherwise.
Common issues:
There is easily another 500 more or more of these, improvement is definitely needed in this area. I'm not sure what needs to be done here as the criteria for maps being marked is not publicized. Even when improvements are made, there needs to be a central location to be able to report unmarked maps so they can be fixed and linked to the Featured Artist listing, as with so many tracks and so many possible tiny variations, it seems impossible to cover every possible case automatically.
The text was updated successfully, but these errors were encountered: