Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarked featured artist maps #8111

Open
NoffyNoffeh opened this issue Sep 10, 2021 · 81 comments
Open

Unmarked featured artist maps #8111

NoffyNoffeh opened this issue Sep 10, 2021 · 81 comments

Comments

@NoffyNoffeh
Copy link
Contributor

It's been a week and from what I recall, we were asked to wait a week before reporting on unmarked FA maps. So here's a list?

google sheet

This list covers 499 ranked and loved maps of featured artist tracks which are not marked as featured artist on the website. I arbitrarily stopped at 499, this list is not fully comprehensive of all unmarked maps. I estimate over a third of all Featured Artist maps of licensed tracks are unmarked.

For tracks with multiple FAs I list only the first. Not sure how this is handled otherwise.

Common issues:

  • Featured artist listing has a / between aliases. The map states only the alias which the song was released under in its artist field. The map ends up unmarked.
  • There is minor formatting differences.
  • (Cut Ver.) maps are not marked
  • Featured artist collabs with another artist, such as with a feat. or other indicative symbol in the artist field. These maps end up unmarked.
  • Markers for length versions, remixes, etc, are usually in light gray text on the FA listing, but are given as (marker) or similar in the template. Maps of these tracks with (marker) do not get marked.
  • Group FAs such as High Tea, MOtOLOiD, Rising Sun Traxx, Tiny Waves, are completely unmarked due to the actual artists being completely different from the FA name.
  • The FA listing and template had errors which were previously fixed in the template, but not on the listing. Or they were not fixed at all, while the ranked/loved map is correct.
  • The track on the FA listing has its title in Japanese, such as *namirin and Trial & Error. Not sure why this leads to unmarked maps.
  • The ranked/loved map has incorrect metadata (usually maps from before an artist was licensed.)

There is easily another 500 more or more of these, improvement is definitely needed in this area. I'm not sure what needs to be done here as the criteria for maps being marked is not publicized. Even when improvements are made, there needs to be a central location to be able to report unmarked maps so they can be fixed and linked to the Featured Artist listing, as with so many tracks and so many possible tiny variations, it seems impossible to cover every possible case automatically.

@peppy
Copy link
Member

peppy commented Sep 10, 2021

No changes have been made to the initial implementation yet. So it can be expected that no changes have been made yet. Please wait a bit longer for this to happen.

Featured artist beatmaps are sourced from ground truth .osz files. Metadata of beatmaps should match them. As long as this matches there should be no issue. If you are to report issues for now, I'd recommend reporting issues with the template files.

For now, to keep traffic low, please keep reports to issues with the templates or listings.

@NoffyNoffeh
Copy link
Contributor Author

NoffyNoffeh commented Sep 10, 2021

The osz files? That doesn't seem right, dozens of items in the list already match the FA osz templates but aren't marked. See for example the Aitsuki Nakuru maps or the Loki / Thaehan maps.

Is there some place to track the status in terms of waiting?

@peppy
Copy link
Member

peppy commented Sep 11, 2021

Let me try again:

For now, please only report issues with the listing or templates rather than beatmaps. These are not yet being used, but that is considered the source of ground truth which will be used going forward.

Tracking waiting can be done by looking at my (private) todo list. So unfortunately not, but I have the task scheduled for this weekend.

@peppy
Copy link
Member

peppy commented Sep 11, 2021

An initial pass has been made to catch the more common issues (1752 -> 2168 for ranked/loved). I haven't gone through your spreadsheet yet, but it'd be appreciated if you can update it as above (listing any FA-side issues) and maybe a bullet point list of any remaining common failure cases (with one beatmap example max). No need for huge lists.

@NoffyNoffeh
Copy link
Contributor Author

Full list of maps found so far which match the template and are unmarked: reference I'm mainly linking this because the reasons why they're unmarked is just guess work and would need further investigation..

I'm working with eiri- to compile FA osz template issues for later, but these are some common cases with already matching map and template which were noticed.

@peppy
Copy link
Member

peppy commented Sep 12, 2021

Ah, case sensitivity was one on my list I completely forgot to apply. That's added an additional couple of hundred mappings (have re-run since).

The metadata issues you point out so fare are going to be resolved in a pass we need to do of some older artists where osz don't match databased metadata.

@peppy
Copy link
Member

peppy commented Sep 12, 2021

I've added some better handling when .osz doesn't match database, should have caught a lot of the edge cases you mentioned above. 37 new tracks matched.

@Hiviexd
Copy link
Member

Hiviexd commented Sep 12, 2021

hi, I found a false positive that's related to the FA tag: https://osu.ppy.sh/beatmapsets/373414#taiko/818079

pretty sure toby fox isn't a featured artist, and clicking the tag sends you to Camellia's FA page

@peppy
Copy link
Member

peppy commented Sep 12, 2021

Thanks, will add a rule against matching on remixes like that (camellia has a remix of that track)

@peppy
Copy link
Member

peppy commented Sep 13, 2021

All of the issues mentioned in #8111 (comment) have been resolved. Let me know if you find any more.

@AncuL001
Copy link

false positive : https://osu.ppy.sh/beatmapsets/1329045#osu/2753127 the remix of this song isn't on the FA

@peppy
Copy link
Member

peppy commented Sep 15, 2021

Thanks, I've unmarked that beatmap and adjusted the rules to better handle remixes (again).

@JBHyperion
Copy link

Found a couple of missing MIMI sets for "Nanimo Nai Youna". Based on beatmapset discussion, seems to be a romanization error on the osz/listing, which reads "Nani mo Nai Youna" (with an additional space): https://osu.ppy.sh/beatmapsets/1151466/discussion/-/generalAll#/1557587

https://osu.ppy.sh/beatmapsets/1151466
https://osu.ppy.sh/beatmapsets/1197461

@Nivalyx
Copy link
Contributor

Nivalyx commented Sep 16, 2021

@peppy would like to report some potential cases of false positives that i found regarding the song "Yuyoyuppe - Palette" :


  1. Yuyoyuppe feat. Hanatan - Palette (http://osu.ppy.sh/s/15951)

this version of the song is an utaite cover of the original vocaloid version (which is licensed), yet somehow it is still tagged as "Featured Artist" in the website. not sure if this is intended behaviour or not tho


  1. Yuyoyuppe - Palette GAMMA (http://osu.ppy.sh/s/409429 / http://osu.ppy.sh/s/679239)

...yeah, i'm pretty sure this one is just a (fanmade?) speed up edit of the song of some sort and by any means not official ;~;

@LittleEndu
Copy link

None of the maps that appear in rejection's news post are actually marked as featured artist maps. All are of the same song, "Signal feat. Such" which appears to be licensed:

Also, can we get confirmation that the detection is run automatically after a new artist is announced? Like how long should we wait to report issues with new artists?

@peppy
Copy link
Member

peppy commented Sep 17, 2021

You should not report issues for new artists. That's out of scope of this thread. Please read my previous comments on what should be posted in this thread.

@NoffyNoffeh
Copy link
Contributor Author

In addition to the ones Niva mentioned, for ones that are falsely flagged or unflagged

  1. Other false flags
    https://osu.ppy.sh/beatmapsets/847415#osu/2177436 the version with this featured singer is not licensed
    https://osu.ppy.sh/beatmapsets/1350334#taiko/2818161 this version is a remaster (indicated by the title changed to remind) and is not licensed.
    https://osu.ppy.sh/beatmapsets/1388590#osu/2867851 this is a remix of the licensed song, it itself is not licensed

  2. Unflagged
    https://osu.ppy.sh/beatmapsets/1388993#osu/2868551 matches template osz but not tagged for some reason?
    https://osu.ppy.sh/beatmapsets/632589 both songs in the map are licensed, they were originally released together https://www.youtube.com/watch?v=E1JcjRRJMEo but for some reason the featured artist listing split them up into two solo tracks. Maybe a third osz with them together like original release would be a solution? Or some way to account for compilations in general, they do happen, especially with metal artists having part 1 / part 2 songs.

  3. There's also quite a few old ARForest maps which list only the singer as the artist, I wouldn't say the osz templates are wrong for saying ARForest feat. Singer, but the maps weren't wrong back then either. Some way to match for just singer in these cases would be helpful.

https://osu.ppy.sh/beatmapsets/12731#osu/47535
https://osu.ppy.sh/beatmapsets/53519#osu/163054
https://osu.ppy.sh/beatmapsets/91606#osu/248001
https://osu.ppy.sh/beatmapsets/39056#osu/124771
https://osu.ppy.sh/beatmapsets/46223#osu/143989

I'm not sure of the current methodology but I think it could work like

  • Check if it matches osz
  • Specifcally check for (Short Ver.) / (Cut Ver.) and match if those are the only difference
  • For some tracks, have set aliases it could match to besides the osz. Similar could be done for artists.
    e.g. Template has Someone feat. Somebody - Title. It could match to maps if they have either Someone, Somebody, or Someone feat. Somebody but NOT Someone feat. Anotherperson

It seems like current matching still misses quite a few things and also picks up other remixes and alternate vocal versions incorrectly.

@peppy
Copy link
Member

peppy commented Sep 23, 2021

No fix has been applied yet for issues I have not replied to as resolved. Please be patient. No need to attempt to define how the process works as I have that under control.

@h3oCharles
Copy link

couple songs didn't get marked that i mapped:

united laos remix https://osu.ppy.sh/beatmapsets/1323369#taiko/2741231

algebra https://osu.ppy.sh/beatmapsets/1285922#taiko/2670153
algebra again but unfinished set https://osu.ppy.sh/beatmapsets/758593#taiko/1595602

@peppy
Copy link
Member

peppy commented Sep 24, 2021

Graveyard is out of scope right now.

@TheMoMan
Copy link

Another false positive same song as #8111 (comment)

https://osu.ppy.sh/beatmapsets/750458#osu/1580331

@peppy
Copy link
Member

peppy commented Oct 6, 2021

@peppy would like to report some potential cases of false positives that i found regarding the song "Yuyoyuppe - Palette" :

  1. Yuyoyuppe feat. Hanatan - Palette (http://osu.ppy.sh/s/15951)

this version of the song is an utaite cover of the original vocaloid version (which is licensed), yet somehow it is still tagged as "Featured Artist" in the website. not sure if this is intended behaviour or not tho

  1. Yuyoyuppe - Palette GAMMA (http://osu.ppy.sh/s/409429 / http://osu.ppy.sh/s/679239)

...yeah, i'm pretty sure this one is just a (fanmade?) speed up edit of the song of some sort and by any means not official ;~;

I honestly think these kinds of edge cases are fine to leave as is. The artist is featured and the tracks are the correct (base) tracks. The main purpose here is providing visibility, not a perfect 1:1 match. So I'm going to leave these for now.

@peppy
Copy link
Member

peppy commented Oct 6, 2021

I've done another update covering hopefully all the issues posted above. Also found around 100 new (ranked) beatmaps in the process.

Please resurface any I may have missed!

@peppy
Copy link
Member

peppy commented Oct 19, 2021

@NoffyNoffeh can i assume that silence here means that things are in a good state, or have you just not had a chance to do another pass?

@AncuL001
Copy link

well uh, you still haven't unmarked the glacierfall remix map i linked

@yasuhosu
Copy link

hi, missing FA marker here:
https://osu.ppy.sh/beatmapsets/1729416#taiko/3534465
This is caused by the template being wrong. instead of Shizukana Yoru ni it is Shizuka na Yoru ni (the na particle is currently not standing alone)
There is this ranked set currently which uses the same title.

@pishifat
Copy link
Contributor

https://osu.ppy.sh/beatmapsets/1885318
another false positive that shouldnt be marked as fa

@SoundBoomer
Copy link

@Wrongwayscout
Copy link

Missing FA marker/incorrect FA listing metadata:
https://osu.ppy.sh/beatmapsets/1428384

Map metadata spells title Veracila (with a c) while featured artist listing spells it Verasila (with an s)

Metadata sources linked in map discussion:
https://osu.ppy.sh/beatmapsets/1428384/discussion/-/generalAll#/2280817

@h3oCharles
Copy link

https://osu.ppy.sh/beatmapsets/2079507 dreaming from twin trials contest has mismatching metadata

@Shompi
Copy link

Shompi commented Dec 7, 2023

https://osu.ppy.sh/beatmapsets/2024359 False positive marked as FA

@cl8n
Copy link
Member

cl8n commented Dec 7, 2023

^ same with https://osu.ppy.sh/beatmapsets/96580
ice cream too strong

@ShiiTsuin
Copy link

https://osu.ppy.sh/beatmapsets/2116675#osu/4448144
Shouldn't be marked as FA, posted on behalf of AirinCat

@pishifat
Copy link
Contributor

missing the fa marker https://osu.ppy.sh/beatmapsets/1972749#osu/4093503
yet https://osu.ppy.sh/beatmapsets/1971987#osu/4091819 has it with the same metadata

the template osz was updated after the first map was ranked, so that may be related

@O1CDeif
Copy link

O1CDeif commented Jan 29, 2024

Also missing the FA marker:

@Ripplechu
Copy link

@Shmiklak
Copy link
Contributor

https://osu.ppy.sh/beatmapsets/1885318#osu/4127309 seems to be false positive as the song isn't available under FA listing

@pishifat
Copy link
Contributor

https://osu.ppy.sh/beatmapsets/2079919#osu/4520026 another false positive (artist has a licensed song called "Moai")

@mcendu
Copy link
Contributor

mcendu commented Jun 12, 2024

https://osu.ppy.sh/beatmapsets/1151089 unmarked, linked in DGK showcase

@R-Trigger
Copy link

R-Trigger commented Jun 20, 2024

https://osu.ppy.sh/beatmapsets/2162219#mania/4559801 The song “rabbit in the black room”is in the fa listing, but there is a remaster ver called “rabbit in the black room(2023 VIP),i havent see this remaster ver in the fa listing but it has fa marked in the information page

@ikin5050
Copy link

https://osu.ppy.sh/beatmapsets/2199195#taiko/4662115 falsely marked as FA because of Silentroom - Angel Echo existing

@Dropinx
Copy link

Dropinx commented Jun 26, 2024

https://osu.ppy.sh/beatmapsets/2203526#taiko/4664066 Missing FA marker, but https://osu.ppy.sh/beatmapsets/1929063#mania/3984270 has it with the same metadata.

@tilda
Copy link

tilda commented Jun 27, 2024

@MolybdenumGaming
Copy link

MolybdenumGaming commented Jun 28, 2024

I've noticed recently that due to the Ranking Criteria's standardization for metadata, certain tracks do not obtain the Featured Artist website tag like they should.

A example of this (which was recently fixed) is "ELFENSJoN - Hyousou wa Hakuen o Matoite", which was originally "ELFENSJoN - Hyousou wa Hakuen wo Matoite" (Ranking Criteria standardizes "wo" to "o" in romanisation)

Another example has popped up, being "uma vs. Morimori Atsushi - Re:End of a Dream" and "uma vs. Morimori Atsushi - Re:End of a Dream (long ver.)" which Ranking Criteria standardizes to "uma vs. Morimori Atsushi - Re: End of a Dream (long ver.)" and "uma vs. Morimori Atsushi - Re: End of a Dream".

One more example is "Papercut - Come Home (ft. Sylvia Bremer)" which would be standardized to "Papercut - Come Home (feat. Sylvia Bremer)"

@Muchin708
Copy link

https://osu.ppy.sh/beatmapsets/421554#osu/4303937
seems to be a false positive as it is totally a different version to the one in the fa listing

@O1CDeif
Copy link

O1CDeif commented Jul 13, 2024

https://osu.ppy.sh/beatmapsets/1175640#osu/2452076
https://osu.ppy.sh/beatmapsets/2180222#fruits/4605320
FA listing has the full version for the download link, which should've been called "Kanata ni Mau wa Sakura no Senritsu / 彼方に舞うは桜の旋律". However the FA listing got it named as "Kanata ni Mau wa Sakura no Shirabe / 彼方に舞うは桜の律べ", which is indeed the shorter version of the same song made for 初音ミク Project DIVA Arcade.

@Ripplechu
Copy link

https://osu.ppy.sh/beatmapsets/2214653#taiko/4692536 N.M.W KINEMA106 unmarked Fa marker

@4lwl4
Copy link

4lwl4 commented Oct 19, 2024

https://osu.ppy.sh/beatmapsets/1795159
no longer has an fa marker after fixing the romanized title to follow standardization

@Glinte
Copy link

Glinte commented Dec 14, 2024

The following two tracks seem to be incorrectly translated in the FA page. Doesn't seem to be a issue with the "feat." part because "Camellia feat. Nanahira - Kizuitara Shunkashuutou" are marked correctly.

Mapset name: Camellia feat. Nanahira - Energy * Drin-ko Fein-chan!
FA page track name: Camellia feat. Nanahira - Energy Doll Ko * Fuin-chan
https://osu.ppy.sh/beatmapsets/257407

Mapsets name: Camellia feat. Nanahira - Energy * Drin-ko Fein-chan! (Camellia's "MONSTERISTIC" D. M. P. Remix)
FA page track name: Camellia - Energy * Drinking Musume * Fein-chan! (Camellia's "MONSTERISTIC" D. M. P. Remix)
https://osu.ppy.sh/beatmapsets/1316055
https://osu.ppy.sh/beatmapsets/883595
https://osu.ppy.sh/beatmapsets/1820163
https://osu.ppy.sh/beatmapsets/1672652

@Susko3
Copy link
Member

Susko3 commented Dec 22, 2024

(quotes from #8111 (comment))

I guess it does depend on how we use the featured artist badge going forward, and whether having these maps marked as such leads to further confusion.

When ppy/osu#31238 goes in, the featured artist badge is going to be more important.

While they aren't 100% correct, I'm not sure these edge cases matter too much. They are harder ones to automate because the titles (like "feat. someone") for a cover are not standard.

The ranking criteria require FA maps to be marked with featured artist tag, maybe using this to give/revoke the featured artist badge is less-error prone. The automation can still be used for linking back to the original song.

How hard is it to change tags on already uploaded beatmapsets?

@Hiviexd
Copy link
Member

Hiviexd commented Dec 22, 2024

The ranking criteria require FA maps to be marked with featured artist tag, maybe using this to give/revoke the featured artist badge is less-error prone. The automation can still be used for linking back to the original song.

Do note that for a long time the featured artist tag was being used for non-licensed songs made by FAs (which shouldn't have the website FA tag applied to them) until this RC proposal got merged, so I wouldn't consider that as a reliable metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests