Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more online metadata controls #11671

Open
Hiviexd opened this issue Nov 21, 2024 · 2 comments
Open

Add more online metadata controls #11671

Hiviexd opened this issue Nov 21, 2024 · 2 comments

Comments

@Hiviexd
Copy link
Member

Hiviexd commented Nov 21, 2024

We currently have the ability to edit tags online, which has come very handy when fixing things in uneditable maps when needed, specifically for Ranked, or soon-to-be-Loved maps with an unavailable mapper, with the latter happening on a monthly basis.

While fixing tags is possible for us, we usually encounter maps that need fixes in other fields (artist/title/source), and for those we have to request peppy for an online fix. I was wondering if it'd be easier for everyone to instead have web capabilities for this, given we already have online tags, and especially with "hax-submits" being out of the picture for good reason.

Needed fields would be:

  • Artist
  • Artist (unicode)
  • Title
  • Title (unicode)
  • Source

Permissions should be identical to the online tags editor.

@Joehuu
Copy link
Member

Joehuu commented Nov 21, 2024

Similar to #10108

@cl8n
Copy link
Member

cl8n commented Dec 4, 2024

Permissions should be identical to the online tags editor.

if added, I think this should be admin-only to heavily discourage its use. there is not yet (and there may never be, bc stable feature lock) a good way to propagate these online changes to every client and this should only be used as a last resort for edits like what you've been doing for Loved

this might just be nerd moment but it bugs me that the online fields communicate something different than what you'd find in the downloaded map. it feels wrong that this is even possible to desync, same with tags, but at least tags aren't important in identifying the map. I've been supportive of having some way to amend metadata of older maps, but that should come with good client support and appropriate safeguards, I'm worried about maps that could become less identifiable by "fixing" their metadata

especially with "hax-submits" being out of the picture for good reason.

kind of tangential, but I would think this can be on the table again with the coming new BSS. for example it could allow admins to update other people's maps as long as they only changed metadata. it might make more technical sense to handle forced metadata changes similar to normal beatmap updates, including updating the .osz/.osus and creating version history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants