Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error experience when configuration file created with type="unknown" #2321

Open
sagerb opened this issue Sep 26, 2024 · 0 comments
Open

Comments

@sagerb
Copy link
Collaborator

sagerb commented Sep 26, 2024

The interface allows the file picker within new deployment flow to select files for which our inspection cannot determine the content-type value (so it sets it to an invalid (according to the schema) "unknown" value).

This is a screenshot of what the user is presented with:
Image

Some additional details:

  • GET configuration does return some info within the configurationError that we process within the UX:
  {
    "configurationName": "multi-type-RKIG",
    "configurationPath": "/Users/billsager/dev/publishing-client-alt/test/sample-content/multi-type/.posit/publish/multi-type-RKIG.toml",
    "configurationRelPath": ".posit/publish/multi-type-RKIG.toml",
    "projectDir": "test/sample-content/multi-type",
    "error": {
      "code": "tomlValidationError",
      "msg": "type: value must be one of \"html\", \"jupyter-notebook\", \"jupyter-voila\", \"python-bokeh\", \"python-dash\", \"python-fastapi\", \"python-flask\", \"python-shiny\", \"python-streamlit\", \"quarto-shiny\", \"quarto\", \"r-plumber\", \"r-shiny\", \"rmd-shiny\", \"rmd\"",
      "operation": "",
      "data": {}
    }
  },

It is thought that we could handle this error much more specifically and improve the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant