Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine callback functions check_item_type(s) and move to specs #912

Open
kevinlacaille opened this issue Apr 6, 2023 · 1 comment
Open
Labels
CLI/SDK Interface Update the CLI and SDK to the finalized interface proposal

Comments

@kevinlacaille
Copy link
Contributor

In planet.cli.data and planet.cli.subscriptions, we have identical pairs of callback functions: check_item_type and check_item_types, which were temporarily introduced in #905. These two functions are incredibly similar and we could probably be do with just one of them.

  1. Let's explore the possibility of removing one of the two callback functions in order to reduce complexity.
  2. Let's move these callback function(s) to planet.specs and update the Data and Subscriptions CLIs, the callback function(s) tests.
@kevinlacaille kevinlacaille added proposal CLI/SDK Interface Update the CLI and SDK to the finalized interface labels Apr 6, 2023
@ischneider
Copy link
Member

Consider using a click ParamType for reuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI/SDK Interface Update the CLI and SDK to the finalized interface proposal
Projects
None yet
Development

No branches or pull requests

3 participants