Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter jars not getting downloaded #1051

Closed
piyuverma opened this issue Nov 6, 2019 · 26 comments
Closed

Twitter jars not getting downloaded #1051

piyuverma opened this issue Nov 6, 2019 · 26 comments

Comments

@piyuverma
Copy link

Build failure while fetching twitter jars.

@HenryCaiHaiying
Copy link
Contributor

HenryCaiHaiying commented Nov 6, 2019 via email

@HenryCaiHaiying
Copy link
Contributor

HenryCaiHaiying commented Nov 6, 2019 via email

@HenryCaiHaiying
Copy link
Contributor

HenryCaiHaiying commented Nov 6, 2019 via email

@sreeram26
Copy link

Do we have any updates on this?

@HenryCaiHaiying
Copy link
Contributor

HenryCaiHaiying commented Nov 9, 2019 via email

@sreeram26
Copy link

sreeram26 commented Nov 9, 2019

Sorry I don't quiet follow.
I see https://maven.twttr.com/com/twitter/maven-finagle-thrift-plugin/0.0.9/ also missing the corresponding jar?
Same case with most other repositories in twitter. What would be the exact change in settings.xml which would solve this?

@HenryCaiHaiying
Copy link
Contributor

HenryCaiHaiying commented Nov 9, 2019 via email

@sreeram26
Copy link

sreeram26 commented Nov 11, 2019

I tried that

:secor_local sreeram.ramji$ cat settings.xml
<?xml version="1.0" encoding="UTF-8"?>
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 http://maven.apache.org/xsd/settings-1.0.0.xsd">
  <mirrors>
    <mirror>
      <id>maven-central</id>
      <name>Maven Central</name>
      <url>http://repo1.maven.org/maven2</url>
      <mirrorOf>twitter</mirrorOf>
    </mirror>
  </mirrors>
</settings>
secor_local sreeram.ramji$ mvn -U -s settings.xml package
[INFO] Scanning for projects...
[ERROR] Failed to execute goal on project secor: Could not resolve dependencies for project com.pinterest:secor:jar:0.29-SNAPSHOT: The following artifacts could not be resolved: com.hadoop.gplcompression:hadoop-lzo:jar:0.4.16, com.twitter.common.zookeeper:lock:jar:0.0.7: Could not find artifact com.hadoop.gplcompression:hadoop-lzo:jar:0.4.16 in maven-central (http://repo1.maven.org/maven2) -> [Help 1]

As these are not present in maven central's repo too see http://repo1.maven.org/maven2/com/hadoop/compression/hadoop-gpl-compression/0.1.0/

@HenryCaiHaiying
Copy link
Contributor

HenryCaiHaiying commented Nov 11, 2019 via email

@sreeram26
Copy link

Yes exactly, and the twitter's maven repo seems to miss the corresponding jars.
One example is
https://maven.twttr.com/com/hadoop/gplcompression/hadoop-lzo/0.4.20/

Raised twitter/hadoop-lzo#140, but no updates so far. Similarly for all of the other jars available only in twitter's maven repo.

@HenryCaiHaiying
Copy link
Contributor

HenryCaiHaiying commented Nov 11, 2019 via email

@piyuverma
Copy link
Author

No, for 0.4.16 hadoop-lzo also, just the .pom files and md5 and sha1 hash files are there but not the actual .jar file.

@msilvestre
Copy link

Is there any workaround for this issue?

@guillem
Copy link

guillem commented Nov 12, 2019

Do we know what's going on with Twitter? Is this a mistake or they've removed the files for good?
Since they're still publishing the hashes, can someone who still has the files at least share them please, so we can manually make the compilation work? Thanks.

@piyuverma
Copy link
Author

piyuverma commented Nov 12, 2019

I have all the jars except for the finagle plugin, i tried commenting out the plugin in pom and with installing all the jars locally in order to get away with the compile time build error. The build succeeded, but got NoClassDefFoundError at runtime for one of the Class InetSocketAddressHelper.java present in net-util.jar. However, that class was present at compile time.
Please download jars here https://drive.google.com/open?id=1WpVlxvJZ5Ip-o9zIg3Q8QsIzormrdzTy

@msilvestre
Copy link

Any news regarding this issue?

@HenryCaiHaiying
Copy link
Contributor

HenryCaiHaiying commented Nov 27, 2019

Got some feedback from https://gitter.im/twitter/finagle, they asked us to upgrade finagle-maven-plugin to scrooge-maven-plugin

@sreeram26
Copy link

sreeram26 commented Nov 27, 2019

There are other dependencies from twitter like https://maven.twttr.com/com/twitter/common/zookeeper/lock/ what are your plans for that?

Sreerams-MacBook-Pro-2:secor sreeram.ramji$ mvn dependency:tree | grep twitter
[INFO] |  \- com.twitter.elephantbird:elephant-bird-core:jar:4.4:compile
[INFO] |     +- com.twitter.elephantbird:elephant-bird-hadoop-compat:jar:4.4:compile
[INFO] |  +- com.twitter.elephantbird:elephant-bird-pig:jar:4.4:compile
[INFO] +- com.twitter.common.zookeeper:lock:jar:0.0.7:compile
[INFO] |  +- com.twitter.common.zookeeper:client:jar:0.0.7:compile
[INFO] |  |  +- com.twitter.common:net-util:jar:0.0.29:compile
[INFO] |  |  |  \- com.twitter.common:collections:jar:0.0.34:compile
[INFO] |  |  \- com.twitter.common:quantity:jar:0.0.30:compile
[INFO] |  +- com.twitter.common:base:jar:0.0.38:compile
[INFO] |  |  \- com.twitter.common:util-system-mocks:jar:0.0.26:compile
[INFO] \- com.twitter:ostrich_2.10:jar:9.18.0:compile
[INFO]    +- com.twitter:util-core_2.10:jar:6.34.0:compile
[INFO]    |  +- com.twitter:util-function_2.10:jar:6.34.0:compile
[INFO]    |  \- com.twitter:jsr166e:jar:1.0.0:compile
[INFO]    +- com.twitter:util-eval_2.10:jar:6.34.0:compile
[INFO]    +- com.twitter:util-logging_2.10:jar:6.34.0:compile
[INFO]    |  +- com.twitter:util-app_2.10:jar:6.34.0:compile
[INFO]    |  |  \- com.twitter:util-registry_2.10:jar:6.34.0:compile
[INFO]    |  \- com.twitter:util-stats_2.10:jar:6.34.0:compile
[INFO]    |     \- com.twitter:util-lint_2.10:jar:6.34.0:compile
[INFO]    +- com.twitter:util-jvm_2.10:jar:6.34.0:compile
[INFO]    \- com.twitter:scala-json_2.10:jar:3.0.2:compile

I had to manually add

$ ls
base-0.0.38.jar			client-0.0.7.jar		collections-0.0.34.jar		hadoop-lzo-0.4.16.jar		lock-0.0.7.jar			net-util-0.0.29.jar		quantity-0.0.30.jar		util-system-mocks-0.0.26.jar

to make the build pass

@HenryCaiHaiying
Copy link
Contributor

One at a time, I am upgrading maven-plugin first, to see if this PR can pass through build:
#1087

@HenryCaiHaiying
Copy link
Contributor

Looks like we passed maven plugin block, now it's stuck at:

The following artifacts could not be resolved: com.hadoop.gplcompression:hadoop-lzo:jar:0.4.16, com.twitter.common.zookeeper:lock:jar:0.0.7, com.twitter.common.zookeeper:client:jar:0.0.7, com.twitter.common:net-util:jar:0.0.29, com.twitter.common:collections:jar:0.0.34, com.twitter.common:quantity:jar:0.0.30, com.twitter.common:base:jar:0.0.38, com.twitter.common:util-system-mocks:jar:0.0.26:

@HenryCaiHaiying
Copy link
Contributor

Almost all twitter.common jars are pulled in because of com.twitter.common.zookeeper:lock:jar:0.0.7, twitter people asked us to upgrade to finagle-serverset

@HenryCaiHaiying
Copy link
Contributor

Actually apache.curator package is probably more appropriate for zookeeper locks

@HenryCaiHaiying
Copy link
Contributor

Made another commit to use apache.curator: #1087

Now we are only missing one jar: com.hadoop.gplcompression:hadoop-lzo:jar:0.4.16,

And this is pulled from this path:

[INFO] +- org.apache.parquet:parquet-protobuf:jar:1.9.0:compile
[INFO] | - com.twitter.elephantbird:elephant-bird-core:jar:4.4:compile
[INFO] | +- com.twitter.elephantbird:elephant-bird-hadoop-compat:jar:4.4:compile
[INFO] | +- com.googlecode.json-simple:json-simple:jar:1.1:compile
[INFO] | - com.hadoop.gplcompression:hadoop-lzo:jar:0.4.16:compile

@HenryCaiHaiying
Copy link
Contributor

Made one more fix in pom.xml to get rid of the dependency on hadoop-lzo, let's see how far the build is going this time

@HenryCaiHaiying
Copy link
Contributor

Make another fix: #1090

Looks like the build is working now.

@guillem
Copy link

guillem commented Dec 2, 2019

Thank you guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants