Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to existing codemods for dist imports #599

Open
Tracked by #176
thatblindgeye opened this issue Feb 28, 2024 · 0 comments
Open
Tracked by #176

Add tests to existing codemods for dist imports #599

thatblindgeye opened this issue Feb 28, 2024 · 0 comments
Assignees
@thatblindgeye
Labels
codemod enhancement New feature or request post v6

Comments

@thatblindgeye
Copy link
Collaborator

thatblindgeye commented Feb 28, 2024 •
edited
Loading

We should add additional tests to check that imports from dist work as intended, especially for rules related to updating import paths from react-core to deprecated or next to react-core.

This should include imports from dist/[esm|js|dynamic]/...

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@wise-king-sullyman wise-king-sullyman added this to the Penta beta release milestone Feb 28, 2024
@andrew-ronaldson andrew-ronaldson mentioned this issue Feb 29, 2024
Open
@tlabaj tlabaj added the codemod label Mar 13, 2024
@thatblindgeye thatblindgeye added the enhancement New feature or request label May 20, 2024
@thatblindgeye thatblindgeye changed the title Chip deprecated rule - add additional tests Add tests to existing codemods for dist imports May 20, 2024
@thatblindgeye thatblindgeye mentioned this issue May 20, 2024
Closed
@thatblindgeye thatblindgeye self-assigned this Jul 25, 2024
@thatblindgeye thatblindgeye removed this from the Penta final release milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
codemod enhancement New feature or request post v6
Projects
PatternFly Issues
Status: Not started
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wise-king-sullyman @tlabaj @thatblindgeye