Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version component is incorrectly lowercased #27

Open
rikkuness opened this issue Jul 8, 2021 · 0 comments
Open

Version component is incorrectly lowercased #27

rikkuness opened this issue Jul 8, 2021 · 0 comments

Comments

@rikkuness
Copy link

For types such as github, the specification states that name should be lowercased, but not the version.
https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#github

Git tags and branches however can be case sensitive.

Looking at the code the functiontypeAdjustName not only passes the name, but is passing name and version, eg. purl-spec@244fd47e07d1004 and as such the version gets lowercased along with the name.

https://github.com/package-url/packageurl-go/blob/master/packageurl.go#L267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants