Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed change in master/primary election on P4Runtime server not implemented. #553

Open
prakashbadri opened this issue May 24, 2021 · 1 comment

Comments

@prakashbadri
Copy link

prakashbadri commented May 24, 2021

The following change proposed in V1.1.0 of the P4Runtime specification is not being handled in the current PI implementation:
"""
A.1.3. Changes in v1.1.0
Major overhaul of master-arbitration: while the Protobuf messages did not change, the state machine that the server needs to implement is significantly different. Upon the master disconnection, the server no longer chooses the controller with the second highest election id as the new master. Instead, there will not be a new master until one of the controllers advertises an election id higher than any election id seen previously.
""""

I see that the current server implementation does reelect the client with the next highest election id as the new primary. Instead the new expectation is that the server does not recompute a new primary when the current primary goes away. I am fixing it. But wanted to check with the group as well.

@antoninbas
Copy link
Member

That's correct. It has not been updated yet. Feel free to open a PR if you want to fix it, otherwise I'm sure I'll eventually get to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants