Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official releases/tags? #31

Open
jmartens opened this issue Feb 20, 2023 · 6 comments
Open

Official releases/tags? #31

jmartens opened this issue Feb 20, 2023 · 6 comments

Comments

@jmartens
Copy link

jmartens commented Feb 20, 2023

Could you create official releases or at least tags? That way it is easier to pin streamserver to a specific commit.

In my case it seems my local ESP device is not working with the current tip of master, but it is very hard to downgrade streamserver.

External components only tage branches or tags apparently if I consult the docs at https://esphome.io/components/external_components.html#external-components-git

@jmartens jmartens changed the title Official releases? Official releases/tags? Feb 20, 2023
@oxan
Copy link
Owner

oxan commented Feb 20, 2023

You can actually specify any git ref (including a commit sha) for external components, it's probably documented as branch or tag to keep it understandable for beginners.

However, actually tagging a release isn't a bad idea. If I do that, it'll be current master though, not an old version.

In my case it seems my local ESP device is not working with the current tip of master

What's not working?

@jmartens
Copy link
Author

Somehow I lost all transmission of P1 smart energy meter after january 28th at least no data is present anymore in the Energy panel.

Still debugging why, so far I can see multiple possible causes:

  • changes to the serialserver code base since the last working update of my ESP device, hence my request for releases. Will see if working with a commit hash makes any difference, at least I can perhaps pinpoint if it is the code base, at what point in the code base it might be introduced.
  • no telegrams are actually transmitted to the ESP device anymore
  • ESPHome encryption feature needs implementation
  • ... perhaps something else I overlooked

@jmartens
Copy link
Author

You can actually specify any git ref (including a commit sha) for external components, it's probably documented as branch or tag to keep it understandable for beginners.

Have not seem to get it working, either:

  Remote branch master@43ade65d088d99a6f1bb2da32f7cdd666eb4eb59 not found in upstream origin.
  source: 
    type: git
    url: https://github.com/oxan/esphome-stream-server
    ref: master@43ade65d088d99a6f1bb2da32f7cdd666eb4eb59

or

  Remote branch 43ade65d088d99a6f1bb2da32f7cdd666eb4eb59 not found in upstream origin.
  source: 
    type: git
    url: https://github.com/oxan/esphome-stream-server
    ref: 43ade65d088d99a6f1bb2da32f7cdd666eb4eb59

when validating/building the yaml.

@jmartens
Copy link
Author

Checked the source (https://github.com/esphome/esphome/blob/dev/esphome/git.py#L64-L75), and AFAICT they do not support specific branch/commit references

@oxan
Copy link
Owner

oxan commented Feb 20, 2023

Hmm, you're right, that's a bit disappointing it only does it for PRs.

I'll make a release when I've a bit more time to do it properly, but in the meantime I've pushed the async-tcp branch with the last commit pre-socket refactor which you can use for testing.

@jmartens
Copy link
Author

  • ... perhaps something else I overlooked

Indeed. Turned out to be faulty hardware, had to change a FET due to a short circuit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants