Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prettier plugin with prettier config in eslint #12051

Open
LukasHirt opened this issue Dec 20, 2024 · 0 comments
Open

Replace prettier plugin with prettier config in eslint #12051

LukasHirt opened this issue Dec 20, 2024 · 0 comments
Labels
Category:Technical Technical ehancements

Comments

@LukasHirt
Copy link
Collaborator

In our eslint config, we're using the prettier plugin which is discouraged. Generally it tends to have poor performance due to the difference in how eslint and prettier are running. Also, it turns out it does not play well with IDE as e.g. I am often getting prettier errors by eslint that are conflicting with the prettier itself causing problems with my automatic formatting. I would suggest we move to the recommended eslint prettier config instead. This would disable conflicting rules in eslint and would leave the formatting to prettier which is what should be used for it. Some more context on all of this https://prettier.io/docs/en/integrating-with-linters.html

Ref:

import eslintConfigPrettier from 'eslint-plugin-prettier/recommended'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Technical Technical ehancements
Projects
Status: Qualification
Development

No branches or pull requests

1 participant