Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar is overlapping content of file picker ("Save as" / "Open") #11875

Open
JammingBen opened this issue Nov 8, 2024 · 6 comments · May be fixed by #12058
Open

Sidebar is overlapping content of file picker ("Save as" / "Open") #11875

JammingBen opened this issue Nov 8, 2024 · 6 comments · May be fixed by #12058
Assignees
Labels
Priority:p4-low Low priority Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Contributor

Describe the bug

The right sidebar is overlapping the content of the file picker ("Save as" / "Open" actions) if opened.

Steps to reproduce

  1. Open a text file
  2. Open the right sidebar
  3. From the context menu, click "Save as" or "Open"

Expected behavior

The sidebar should not be visible in the file picker.

Actual behavior

It's visible and overlapping all the content.

@JammingBen JammingBen added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Nov 8, 2024
@JammingBen JammingBen moved this from Qualification to Prio 3 or less in Infinite Scale Team Board Nov 8, 2024
@AlexAndBear
Copy link
Contributor

Now, that I fixed the modal width is this issue still relevant ?

@JammingBen
Copy link
Contributor Author

I'd say yes, because the problem still becomes a thing on smaller screens and on mobile.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Nov 14, 2024

Got you. As of now I can't think of a proper solution as the iframe and the window do share the same local storage

@JammingBen
Copy link
Contributor Author

True, hmmm. All solutions I can think of are somewhat hacky... Maybe just ignore the sidebar storage setting in embed mode and use a local state in the useSideBar composable instead? Would be sufficient for an embedded Web I guess.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Nov 14, 2024

I am not 100% sure about that, @kulmann and me already talked about it in the reviews and decided to leave it as it is. I suggest to give it p4, now we have the width fixed and decide on a solution later

@JammingBen JammingBen added Priority:p4-low Low priority and removed Type:Bug Something isn't working labels Nov 14, 2024
@JammingBen
Copy link
Contributor Author

Fine be me!

@JammingBen JammingBen added Type:Bug Something isn't working and removed Priority:p3-medium Normal priority labels Nov 14, 2024
@LukasHirt LukasHirt self-assigned this Dec 27, 2024
@LukasHirt LukasHirt moved this from Prio 3 or less to blocked in Infinite Scale Team Board Dec 27, 2024
@LukasHirt LukasHirt moved this from blocked to In progress in Infinite Scale Team Board Dec 27, 2024
@LukasHirt LukasHirt linked a pull request Dec 27, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p4-low Low priority Type:Bug Something isn't working
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants