Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button alignment oauth screen #11915

Closed
2 tasks done
DeepDiver1975 opened this issue Sep 27, 2024 · 6 comments · Fixed by #11931
Closed
2 tasks done

button alignment oauth screen #11915

DeepDiver1975 opened this issue Sep 27, 2024 · 6 comments · Fixed by #11931
Assignees
@erikjv
Milestone
Desktop 6.0

Comments

@DeepDiver1975
Copy link
Member

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

buttons are miss aligned

Expected behavior

shall be alligned

Steps to reproduce the issue

No response

Screenshots

image

Logs

No response

Client version number

master

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

No response

Server information

No response

Additional context

No response
@DeepDiver1975 DeepDiver1975 added this to the Desktop 6.0 milestone Sep 30, 2024
@erikjv erikjv self-assigned this Oct 2, 2024
@erikjv
Copy link
Collaborator

erikjv commented Oct 2, 2024

I cannot reproduce this on my macOS build. This is probably on Linux, so I'll try that next.

@erikjv
Copy link
Collaborator

erikjv commented Oct 2, 2024

I tried to reproduce this on Neon Linux (Wayland), and for me it looks fine:

Screenshot 2024-10-02 at 16 27 53

@erikjv
Copy link
Collaborator

erikjv commented Oct 2, 2024 •
edited
Loading

What Qt version are you using? Or, is this a craft build, or a native Linux build?

@DeepDiver1975
Copy link
Member Author

I tried to reproduce this on Neon Linux (Wayland), and for me it looks fine:

git the 'open browser' button and see the text change ...

@erikjv
Copy link
Collaborator

erikjv commented Oct 8, 2024

I can reproduce this now.

erikjv added a commit that referenced this issue Oct 8, 2024
@erikjv
Fix button alignment in oauth screen
49ae25f 
When an item is in a layout, the width property is ignored, and the
implicitWidth is used. So the copy-to-clipboard button's preferredWidth
should be bound the implicitWidth property of the open-browser button.

Fixes: #11915
@erikjv erikjv mentioned this issue Oct 8, 2024
Closed
@erikjv erikjv removed the Needs info label Oct 8, 2024
erikjv added a commit that referenced this issue Oct 15, 2024
@erikjv
Fix button alignment in oauth screen
695efa6 
When an item is in a layout, the width property is ignored, and the
implicitWidth is used. So the copy-to-clipboard button's preferredWidth
should be bound the implicitWidth property of the open-browser button.

Fixes: #11915
erikjv added a commit that referenced this issue Oct 15, 2024
@erikjv
Fix button alignment in oauth screen
2ee09c0 
When an item is in a layout, the width property is ignored, and the
implicitWidth is used. So the copy-to-clipboard button's preferredWidth
should be bound the implicitWidth property of the open-browser button.

Fixes: #11915
@erikjv erikjv mentioned this issue Oct 15, 2024
Merged
DeepDiver1975 pushed a commit that referenced this issue Oct 15, 2024
@erikjv
fix: button alignment in oauth screen (#11931)
1717fdc 
When an item is in a layout, the width property is ignored, and the
implicitWidth is used. So the copy-to-clipboard button's preferredWidth
should be bound the implicitWidth property of the open-browser button.

Fixes: #11915
@saw-jan
Copy link
Member

saw-jan commented Oct 29, 2024

Tested with: ownCloud 6.0.0.14906-daily20241029 [b056cf]

  1. Open new account wizard
  2. Click open web browser

Screenshot from 2024-10-29 13-57-51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
None yet
Projects
None yet
Milestone
Desktop 6.0
3 participants
@erikjv @DeepDiver1975 @saw-jan