Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: Update/#222 product page update #307 #312

Open
ciaranschutte opened this issue Sep 7, 2023 · 0 comments
Open

Feedback: Update/#222 product page update #307 #312

ciaranschutte opened this issue Sep 7, 2023 · 0 comments
Labels
new-feature Request is a new feature

Comments

@ciaranschutte
Copy link
Contributor

ciaranschutte commented Sep 7, 2023

Screenshot 2023-09-07 at 2 32 52 PM

  • Github, User Docs "button style links", "Installation Instructions" don't go anywhere
  • the info sections eg. "Metadata Validation" have the "pointer" cursor (cursor: pointer) which tells the user it's clickable.... but these sections aren't clickable

https://github.com/overture-stack/website/blob/develop/src/components/LinkHelper/index.js

  • use const
  let isBrowser = typeof window !== 'undefined';
  let width = isBrowser && window.innerWidth;
  const mobileViewPort = isBrowser && width <= 767;
  const tabletViewPort = isBrowser && 767 < width && width <= 1023;
  const desktopViewPort = isBrowser && 1023 < width && width <= 1215;
  const desktopWideViewPort = isBrowser && 1215 < width && width <= 1407;
  const desktopUltraWideViewPort = isBrowser && 1408 < width;
  • use regular css?

font size use rem


      className={`yellow-button__text ${isProductPage && 'yellow-button__product-page-text'}`}

why logic?


half bem / half logic css?


duplicate images. variations on sizes as indivual images when theyre svgs you can resize.

@ciaranschutte ciaranschutte added the new-feature Request is a new feature label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Request is a new feature
Projects
None yet
Development

No branches or pull requests

1 participant