Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of functional tests for Stack #9388

Open
fviernau opened this issue Nov 6, 2024 · 2 comments
Open

Reduce size of functional tests for Stack #9388

fviernau opened this issue Nov 6, 2024 · 2 comments
Labels
analyzer About the analyzer tool good first issue An easy issue for new contributors tech debt Technical debt that should be addressed

Comments

@fviernau
Copy link
Member

fviernau commented Nov 6, 2024

The expected results are so large that using IntelliJ for editing and meld for comparing diffs is not feasible.
Also reviewing a diff in GitHub UI will probably be impossible.

Goal: Reduce the size of the dependency trees of the test project(s), to address above issue plus maybe also the execution time.

@fviernau fviernau added tech debt Technical debt that should be addressed good first issue An easy issue for new contributors analyzer About the analyzer tool labels Nov 6, 2024
@sschuberth
Copy link
Member

Couldn't that be solved by finally migrating the Stack implementation to the dependency graph (see #3825) and comparing the more compact representations?

@fviernau
Copy link
Member Author

fviernau commented Nov 6, 2024

Couldn't that be solved by finally migrating the Stack implementation to the dependency graph (see #3825) and comparing the more compact representations?

IIUC we never compare the dependency graph representation as that would be too cryptic (e.g. array indices and so forth), but use the legacy representation for human readability in expected results. So, I believe that wouldn't be a feasible solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer About the analyzer tool good first issue An easy issue for new contributors tech debt Technical debt that should be addressed
Projects
None yet
Development

No branches or pull requests

2 participants