Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling of Zipkin Reporter 4 #247

Open
codefromthecrypt opened this issue Jan 22, 2024 · 1 comment
Open

Scheduling of Zipkin Reporter 4 #247

codefromthecrypt opened this issue Jan 22, 2024 · 1 comment

Comments

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Jan 22, 2024

There are outside consumers of the sender libraries, so we should be careful about when we release zipkin-reporter 4, and possibly how we release it. It should be as late as possible, to impact folks least, and move the floor java version from 1.6 to 8.

on move from Java 1.6 to 8 floor: yes, when forced by toolchain

So, this shouldn't happen until after using JDK11 becomes a problem, noting official EOL may happen soon, but on the other hand, azul will likely support it for a long time. Remember JDK 11 is the last to support compiling Java 1.6.

on removing deprecation: yes, but that's not timeline driving

When we do reporter 4 we should also remove deprecated functions, however unlike reporter 3 deprecation removal isn't terribly important. In other words, we don't need to use deprecation as the reason to push 4, rather something around our ability to compile or run tests.

on package/groupId change: probably should

We might consider changing the group ID and even the package name when we release 4. We didn't on 3 because it would have been a lot of work due to complexity of the Call type. Since that isn't used anymore, we could consider abandoning the old package and move from reporter2 to reporter4 this time. This is because the sender is a very simple type now. If we did that, it would break people less, as they could still depend on both jars.

@codefromthecrypt
Copy link
Member Author

cc @anuraaga @shakuzen @reta just capturing thoughts here. as described this shouldn't happen this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant