From e0abf14ff47fadf92c95b61f906bef00dbe3a86a Mon Sep 17 00:00:00 2001
From: Brendan Shephard <bshephar@redhat.com>
Date: Mon, 3 Jul 2023 11:49:27 +1000
Subject: [PATCH] Add startupProbe for Horizon pod

The Horizon pod is fairly frequently killed due to the current liveness
probe timing. This seems to happen more frequently during the initial
deployment while the system is under load. This change adds the
startup probe to provide some extra time for kubelet to validate the
functionality of the Horizon pod before terminating it.

Signed-off-by: Brendan Shephard <bshephar@redhat.com>
---
 pkg/horizon/deployment.go | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/pkg/horizon/deployment.go b/pkg/horizon/deployment.go
index 174aba7b..6971637e 100644
--- a/pkg/horizon/deployment.go
+++ b/pkg/horizon/deployment.go
@@ -38,9 +38,9 @@ func Deployment(instance *horizonv1.Horizon, configHash string, labels map[strin
 
 	args := []string{"-c", ServiceCommand}
 	livenessProbe := &corev1.Probe{
-		TimeoutSeconds:      5,
-		PeriodSeconds:       10,
-		InitialDelaySeconds: 10,
+		TimeoutSeconds:      15,
+		PeriodSeconds:       5,
+		InitialDelaySeconds: 15,
 		ProbeHandler: corev1.ProbeHandler{
 			HTTPGet: &corev1.HTTPGetAction{
 				Path: "/dashboard/auth/login/?next=/dashboard/",
@@ -49,9 +49,21 @@ func Deployment(instance *horizonv1.Horizon, configHash string, labels map[strin
 		},
 	}
 	readinessProbe := &corev1.Probe{
-		TimeoutSeconds:      5,
-		PeriodSeconds:       10,
-		InitialDelaySeconds: 10,
+		TimeoutSeconds:      25,
+		PeriodSeconds:       5,
+		InitialDelaySeconds: 15,
+		ProbeHandler: corev1.ProbeHandler{
+			HTTPGet: &corev1.HTTPGetAction{
+				Path: "/dashboard/auth/login/?next=/dashboard/",
+				Port: intstr.IntOrString{IntVal: 80},
+			},
+		},
+	}
+
+	startupProbe := &corev1.Probe{
+		TimeoutSeconds:      30,
+		PeriodSeconds:       60,
+		InitialDelaySeconds: 60,
 		ProbeHandler: corev1.ProbeHandler{
 			HTTPGet: &corev1.HTTPGetAction{
 				Path: "/dashboard/auth/login/?next=/dashboard/",
@@ -101,6 +113,7 @@ func Deployment(instance *horizonv1.Horizon, configHash string, labels map[strin
 							Resources:      instance.Spec.Resources,
 							ReadinessProbe: readinessProbe,
 							LivenessProbe:  livenessProbe,
+							StartupProbe:   startupProbe,
 							Ports: []corev1.ContainerPort{
 								{
 									Name:          "http",