Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a toolkit registry through to SystemGenerator #285

Open
IAlibay opened this issue Jul 5, 2023 · 2 comments
Open

Allow passing a toolkit registry through to SystemGenerator #285

IAlibay opened this issue Jul 5, 2023 · 2 comments

Comments

@IAlibay
Copy link

IAlibay commented Jul 5, 2023

The template generators do:

  1. A lot of to_smiles and from_smiles calls when caching parameters.
  2. A toolkit dependent openmm system creation call.

It would be great if we could pass through a registry so we can ensure we are consistently creating parameters and writing / reading from cache across multiple environments.

For context: we realised this was an issue where a system we were testing in OpenFE was working fine with RDKit, but kept crashing with environments that had OEChem present. It would be great for us to ensure reproducibility if we just could allow only the rdkit interface to be used by default.

@mikemhenry
Copy link
Collaborator

This will be a bit tricky since then we need to store the toolkit used when making the molecule. I understand why this is important.

@mattwthompson
Copy link
Collaborator

The toolkit has a (⏰ private ⏰) context manager for this sort of behavior: https://github.com/openforcefield/openff-toolkit/blob/0.14.0/openff/toolkit/utils/toolkit_registry.py#L378-L379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants