From efa4896f80b205ad7189b001e90de64aab4089dc Mon Sep 17 00:00:00 2001
From: Wilfried BARADAT <wilfried.baradat@fun-mooc.fr>
Date: Tue, 17 Sep 2024 19:21:35 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A8(project)=20fix=20ruff=20warnings?=
 =?UTF-8?q?=20following=20update?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

After updating Ruff, some rules have changed and warnings are raised. Fixing
them.
---
 src/api/core/warren/tests/indicators/test_mixins.py | 4 ++--
 src/api/core/warren/tests/test_xapi.py              | 4 ++--
 src/app/warren/settings.py                          | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/api/core/warren/tests/indicators/test_mixins.py b/src/api/core/warren/tests/indicators/test_mixins.py
index e9b810ae..79bdc4a1 100644
--- a/src/api/core/warren/tests/indicators/test_mixins.py
+++ b/src/api/core/warren/tests/indicators/test_mixins.py
@@ -265,7 +265,7 @@ class NewIndicator(MyIndicator):
         async def compute(self) -> list:
             pass
 
-    assert NewIndicator()._compute_annotation == list
+    assert NewIndicator()._compute_annotation is list
 
 
 @pytest.mark.anyio
@@ -878,7 +878,7 @@ def merge(a, b) -> list:
         )
     )
 
-    assert indicator._compute_annotation == dict
+    assert indicator._compute_annotation is dict
 
     class MyType(BaseModel):
         foo: str
diff --git a/src/api/core/warren/tests/test_xapi.py b/src/api/core/warren/tests/test_xapi.py
index 8dfac739..45f5e779 100644
--- a/src/api/core/warren/tests/test_xapi.py
+++ b/src/api/core/warren/tests/test_xapi.py
@@ -117,7 +117,7 @@ def test_statements_transformer_add_actor_uid():
     statements = StatementsTransformer.to_datetime(statements)
     statements = StatementsTransformer.add_actor_uid_column(statements)
 
-    assert type(statements) == pd.DataFrame
+    assert type(statements) is pd.DataFrame
     assert "actor.uid" in statements.columns
     assert statements["actor.uid"].notna
     # Check that 2 identical actors have the same UID
@@ -198,7 +198,7 @@ def test_statements_transformer_preprocess_statements_workflow():
 
     statements = StatementsTransformer.preprocess(raw_statements)
 
-    assert type(statements) == pd.DataFrame
+    assert type(statements) is pd.DataFrame
     assert "actor.uid" in statements.columns
     assert statements["actor.uid"].notna
     assert statements["timestamp"].equals(
diff --git a/src/app/warren/settings.py b/src/app/warren/settings.py
index fd39b2a0..fb9e8e2b 100644
--- a/src/app/warren/settings.py
+++ b/src/app/warren/settings.py
@@ -40,7 +40,7 @@ def get_release():
 class Value(values.Value):
     """Custom Value instance that overrides default Value configuration."""
 
-    def __init__(  # noqa: PLR0913
+    def __init__(
         self,
         default=None,
         environ=True,