Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terms and conditions refactoring #816

Closed
lunika opened this issue May 31, 2024 · 1 comment
Closed

Terms and conditions refactoring #816

lunika opened this issue May 31, 2024 · 1 comment
Assignees
@jonathanreveille
Labels
feature

Comments

@lunika
Copy link
Member

lunika commented May 31, 2024 •
edited by jonathanreveille
Loading

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe.

Terms and conditions (CGV in french) must be specific for every organization. This means that we can't have a global one for the whole platform.

Describe the solution you'd like

  • Terms and conditions will be included in the contract definition provided by the organization.
  • There is no more need to accept them in the sale tunnel, they will be signed in the contract (remove this part).
  • There is no more need to store in the order model if the user accept them (remove it from the model).
  • There is no more need to store them in the site model in joanie and in richie.
  • There is no more need to inject them dynamically in the contract, they will be already present.
@lunika lunika added the feature label May 31, 2024
@jonathanreveille jonathanreveille self-assigned this Jun 5, 2024
@jonathanreveille jonathanreveille mentioned this issue Jun 5, 2024
Closed
3 tasks
jonathanreveille added a commit that referenced this issue Jun 10, 2024
@jonathanreveille
♻️(backend) remove has_consent_to_terms for Order model
d1b2e4c 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing. The terms and conditions will be written and stored in the
contract definition body field. There's no need to prepare them
separately for the contract context anymore. We've updated the
contract preparation template by removing the terms_and_conditions
from the Appendices section. The use of SiteConfig to prepare
terms and conditions for a contract in Markdown is now deprecated.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 10, 2024
@jonathanreveille
♻️(backend) remove has_consent_to_terms for Order model
d4d3d11 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing. The terms and conditions will be written and stored in the
contract definition body field. There's no need to prepare them
separately for the contract context anymore. We've updated the
contract preparation template by removing the terms_and_conditions
from the Appendices section. The use of SiteConfig to prepare
terms and conditions for a contract in Markdown is now deprecated.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 10, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
db36ebb 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 10, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
ec576f1 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 11, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
e8719f2 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 11, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
49b7572 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 11, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
9113d20 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 11, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
f89c8fe 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 11, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
7c75213 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 11, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
51b3ec6 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
lunika pushed a commit that referenced this issue Jun 11, 2024
@jonathanreveille @lunika
♻️(backend) deprecate has_consent_to_terms for Order model
613a154 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 11, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
cbe6d58 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 11, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
0dd9c37 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 12, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
06f23d6 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
kernicPanel pushed a commit that referenced this issue Jun 14, 2024
@jonathanreveille @kernicPanel
♻️(backend) deprecate has_consent_to_terms for Order model
7bbfc01 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
@jonathanreveille
Copy link
Member

This issue has been solved and merged into the dev branch
#831

kernicPanel pushed a commit that referenced this issue Jun 20, 2024
@jonathanreveille @kernicPanel
♻️(backend) deprecate has_consent_to_terms for Order model
6d42358 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 26, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
8adfdb0 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 26, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
d6ca6c7 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 26, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
fcdf1b3 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 26, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
1189dce 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 26, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
3354b69 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 26, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
1378ef8 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Jun 26, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
f5ebd46 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
kernicPanel pushed a commit that referenced this issue Jul 2, 2024
@jonathanreveille @kernicPanel
♻️(backend) deprecate has_consent_to_terms for Order model
341c689 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
kernicPanel pushed a commit that referenced this issue Jul 2, 2024
@jonathanreveille @kernicPanel
♻️(backend) deprecate has_consent_to_terms for Order model
c091593 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Jul 17, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
f7f0686 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Jul 25, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
730966d 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Jul 29, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
632c4ec 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Aug 5, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
bb95e5a 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Aug 5, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
a03f907 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Aug 5, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
48f157d 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jonathanreveille added a commit that referenced this issue Aug 5, 2024
@jonathanreveille
♻️(backend) deprecate has_consent_to_terms for Order model
d95f828 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Aug 7, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
c13495a 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Aug 12, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
5ca3090 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Aug 13, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
edd706b 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Aug 19, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
f96896c 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Aug 21, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
87a09b3 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
kernicPanel pushed a commit that referenced this issue Sep 19, 2024
@jonathanreveille @kernicPanel
♻️(backend) deprecate has_consent_to_terms for Order model
dbc1c3c 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Oct 7, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
2bb03f7 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
jbpenrath pushed a commit that referenced this issue Oct 7, 2024
@jonathanreveille @jbpenrath
♻️(backend) deprecate has_consent_to_terms for Order model
6033e98 
From now on, the terms and conditions (CGV in French) must be
specific to each organization. We can no longer use a global
version for the entire platform. These terms will be included
directly in the contract's context, so the Order model no longer
needs to track user acceptance, as this will happen during contract
signing.

Fix #816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanreveille jonathanreveille

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunika @jonathanreveille