From bb95e5afa26c5086cf9c431d08cfbc5b5a8c2244 Mon Sep 17 00:00:00 2001 From: Jonathan Reveille Date: Mon, 10 Jun 2024 18:22:56 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F(backend)=20deprecate=20`has?= =?UTF-8?q?=5Fconsent=5Fto=5Fterms`=20for=20Order=20model?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From now on, the terms and conditions (CGV in French) must be specific to each organization. We can no longer use a global version for the entire platform. These terms will be included directly in the contract's context, so the Order model no longer needs to track user acceptance, as this will happen during contract signing. Fix #816 --- src/backend/joanie/tests/core/test_models_order.py | 12 ------------ src/backend/joanie/tests/swagger/admin-swagger.json | 2 +- src/backend/joanie/tests/swagger/swagger.json | 2 +- 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/backend/joanie/tests/core/test_models_order.py b/src/backend/joanie/tests/core/test_models_order.py index f62e7676f1..82397e7fc0 100644 --- a/src/backend/joanie/tests/core/test_models_order.py +++ b/src/backend/joanie/tests/core/test_models_order.py @@ -1120,18 +1120,6 @@ def test_models_order_has_unsigned_contract_signature(self): ) self.assertFalse(order.has_unsigned_contract) - def test_models_order_has_unsigned_contract_product_contract_definition(self): - """ - Check that the `has_unsigned_contract` property returns True - if the order's contract is not signed by student. - """ - order = factories.OrderFactory( - product__contract_definition=factories.ContractDefinitionFactory() - ) - self.assertTrue(order.has_unsigned_contract) - with self.assertRaises(Contract.DoesNotExist): - order.contract # pylint: disable=pointless-statement - def test_models_order_has_consent_to_terms_should_raise_deprecation_warning(self): """ Due to the refactoring of `has_consent_to_terms` attribute, it is now a deprecated field. diff --git a/src/backend/joanie/tests/swagger/admin-swagger.json b/src/backend/joanie/tests/swagger/admin-swagger.json index 620e59a580..d624a4bfde 100644 --- a/src/backend/joanie/tests/swagger/admin-swagger.json +++ b/src/backend/joanie/tests/swagger/admin-swagger.json @@ -7760,4 +7760,4 @@ } } } -} \ No newline at end of file +} diff --git a/src/backend/joanie/tests/swagger/swagger.json b/src/backend/joanie/tests/swagger/swagger.json index 0557e25ebf..e8326eec0c 100644 --- a/src/backend/joanie/tests/swagger/swagger.json +++ b/src/backend/joanie/tests/swagger/swagger.json @@ -7213,4 +7213,4 @@ } } } -} \ No newline at end of file +}